From reviews-return-75564-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Apr 4 05:48:41 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 17CFF18FFD for ; Wed, 4 Apr 2018 05:48:41 +0000 (UTC) Received: (qmail 57658 invoked by uid 500); 4 Apr 2018 05:48:41 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 57643 invoked by uid 500); 4 Apr 2018 05:48:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 57628 invoked by uid 99); 4 Apr 2018 05:48:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 05:48:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 73212C0047; Wed, 4 Apr 2018 05:48:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.142 X-Spam-Level: ** X-Spam-Status: No, score=2.142 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id rshLlzFbkPmY; Wed, 4 Apr 2018 05:48:38 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 66D365F1B9; Wed, 4 Apr 2018 05:48:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0ABB6E00CA; Wed, 4 Apr 2018 05:48:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id EC354C40575; Wed, 4 Apr 2018 05:48:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8363530617159035101==" MIME-Version: 1.0 Subject: Re: Review Request 66038: Add usageWithInode to check both disk and inode usage. From: Gilbert Song To: Gilbert Song Cc: fei long , mesos Date: Wed, 04 Apr 2018 05:48:37 -0000 Message-ID: <20180404054837.21438.65997@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66038/ X-Sender: Gilbert Song References: <20180313140857.38974.75665@reviews-vm2.apache.org> In-Reply-To: <20180313140857.38974.75665@reviews-vm2.apache.org> Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============8363530617159035101== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66038/#review200427 ----------------------------------------------------------- 3rdparty/stout/include/stout/posix/fs.hpp Lines 55 (patched) as a library in stout, I would suggest to avoid adding `std::max`. Instead, we may want to just implement a function called `inodeUsage()`. We could move the std::max to the caller size, which is more explicit. Thoughts? - Gilbert Song On March 13, 2018, 7:08 a.m., fei long wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66038/ > ----------------------------------------------------------- > > (Updated March 13, 2018, 7:08 a.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-8665 > https://issues.apache.org/jira/browse/MESOS-8665 > > > Repository: mesos > > > Description > ------- > > Add usageWithInode to check both disk and inode usage. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/fs.hpp 269a4f50f1df8d68be9e11030f885cf2c254c9d8 > > > Diff: https://reviews.apache.org/r/66038/diff/2/ > > > Testing > ------- > > No new tests are added and all "make check" tests are passed. > > > Thanks, > > fei long > > --===============8363530617159035101==--