| Zhitao Li |
Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes. |
Mon, 09 Apr, 19:15 |
| Gaston Kleiman |
Re: Review Request 66464: Implemented operation status reconciliation. |
Mon, 09 Apr, 19:26 |
| Gaston Kleiman |
Re: Review Request 66464: Implemented operation status reconciliation. |
Mon, 09 Apr, 19:29 |
| Gaston Kleiman |
Re: Review Request 66464: Implemented operation status reconciliation. |
Mon, 09 Apr, 19:31 |
| Akash Gupta |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Mon, 09 Apr, 20:38 |
| Andrew Schwartzmeyer |
Re: Review Request 66038: Add usageWithInode to check both disk and inode usage. |
Mon, 09 Apr, 20:40 |
| Akash Gupta |
Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `FileEndOfFileInfo`. |
Mon, 09 Apr, 20:42 |
| Andrew Schwartzmeyer |
Re: Review Request 66038: Add usageWithInode to check both disk and inode usage. |
Mon, 09 Apr, 21:01 |
| Andrew Schwartzmeyer |
Re: Review Request 66481: Converted `pid` in command executor to `Option<pid_t>`. |
Mon, 09 Apr, 21:16 |
| Andrew Schwartzmeyer |
Re: Review Request 66493: Made FreeBSD default to non-GNU ld. |
Mon, 09 Apr, 21:22 |
| Gaston Kleiman |
Re: Review Request 66464: Implemented operation status reconciliation. |
Mon, 09 Apr, 21:30 |
| Gaston Kleiman |
Re: Review Request 66464: Implemented operation status reconciliation. |
Mon, 09 Apr, 21:35 |
| Akash Gupta |
Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. |
Mon, 09 Apr, 21:37 |
| Akash Gupta |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Mon, 09 Apr, 21:39 |
| Akash Gupta |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Mon, 09 Apr, 21:51 |
| Gaston Kleiman |
Review Request 66468: Added tests for operation status reconciliation. |
Mon, 09 Apr, 21:53 |
| Andrew Schwartzmeyer |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Mon, 09 Apr, 22:07 |
| Andrew Schwartzmeyer |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Mon, 09 Apr, 22:09 |
| Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Mon, 09 Apr, 22:40 |
| Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Mon, 09 Apr, 22:53 |
| Mesos Reviewbot Windows |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Mon, 09 Apr, 22:54 |
| Mesos Reviewbot |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Mon, 09 Apr, 23:30 |
| Greg Mann |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 00:08 |
| Gaston Kleiman |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 00:30 |
| Gaston Kleiman |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 00:33 |
| Akash Gupta |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Tue, 10 Apr, 01:18 |
| Mesos Reviewbot Windows |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 01:24 |
| Till Toenshoff |
Re: Review Request 65939: Updated role endpoints for hierarchical accounting. |
Tue, 10 Apr, 02:57 |
| Till Toenshoff |
Re: Review Request 65940: Added test validating hierarchical role accounting. |
Tue, 10 Apr, 03:10 |
| Zhitao Li |
Re: Review Request 66050: Implemented grow and shrink of persistent volumes. |
Tue, 10 Apr, 04:18 |
| Zhitao Li |
Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume. |
Tue, 10 Apr, 04:21 |
| Zhitao Li |
Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. |
Tue, 10 Apr, 04:22 |
| Mesos Reviewbot Windows |
Re: Review Request 65940: Added test validating hierarchical role accounting. |
Tue, 10 Apr, 04:28 |
| Zhitao Li |
Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume. |
Tue, 10 Apr, 04:32 |
| Zhitao Li |
Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume. |
Tue, 10 Apr, 04:34 |
| Zhitao Li |
Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume. |
Tue, 10 Apr, 04:34 |
| Mesos Reviewbot Windows |
Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API. |
Tue, 10 Apr, 05:22 |
| Mesos Reviewbot |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 05:38 |
| David Forsythe |
Re: Review Request 66493: Made FreeBSD default to non-GNU ld. |
Tue, 10 Apr, 06:36 |
| David Forsythe |
Re: Review Request 66493: Made FreeBSD default to non-GNU ld. |
Tue, 10 Apr, 06:36 |
| David Forsythe |
Re: Review Request 66493: Made FreeBSD default to non-GNU ld. |
Tue, 10 Apr, 06:47 |
| Mesos Reviewbot Windows |
Re: Review Request 66493: Made FreeBSD default to non-GNU ld. |
Tue, 10 Apr, 07:58 |
| Mesos Reviewbot Windows |
Re: Review Request 66415: Changed SLEEP_COMMAND to use ping instead of powershell Start-Sleep on Windows. |
Tue, 10 Apr, 09:21 |
| Benjamin Bannier |
Review Request 66526: Renamed resource provider `AgentRegistrar` to `GenericRegistrar`. |
Tue, 10 Apr, 12:07 |
| Benjamin Bannier |
Re: Review Request 66311: Implement recovery of resource provider manager. |
Tue, 10 Apr, 12:07 |
| Benjamin Bannier |
Re: Review Request 66308: Delayed construction of the agent's resource provider manager. |
Tue, 10 Apr, 12:07 |
| Benjamin Bannier |
Re: Review Request 66309: Externalize creation of resource provider manager backing storage. |
Tue, 10 Apr, 12:07 |
| Benjamin Bannier |
Re: Review Request 66310: Passed on registrar when constructing resource provider manager. |
Tue, 10 Apr, 12:07 |
| Benjamin Bannier |
Re: Review Request 66309: Externalize creation of resource provider manager backing storage. |
Tue, 10 Apr, 12:08 |
| Benjamin Bannier |
Review Request 66527: Avoided copy in accessing resource provider subscription field. |
Tue, 10 Apr, 12:56 |
| Benjamin Bannier |
Review Request 66528: Added logging of failed resource provider registry updates. |
Tue, 10 Apr, 12:56 |
| Jan Schlicht |
Re: Review Request 66311: Implement recovery of resource provider manager. |
Tue, 10 Apr, 13:05 |
| Mesos Reviewbot Windows |
Re: Review Request 66311: Implement recovery of resource provider manager. |
Tue, 10 Apr, 13:29 |
| Mesos Reviewbot |
Re: Review Request 66493: Made FreeBSD default to non-GNU ld. |
Tue, 10 Apr, 13:41 |
| Jan Schlicht |
Re: Review Request 66508: Made sure test agent has reached stable state before starting test. |
Tue, 10 Apr, 14:15 |
| Jan Schlicht |
Re: Review Request 66527: Avoided copy in accessing resource provider subscription field. |
Tue, 10 Apr, 14:18 |
| Jan Schlicht |
Re: Review Request 66528: Added logging of failed resource provider registry updates. |
Tue, 10 Apr, 14:20 |
| Benno Evers |
Re: Review Request 63366: Add jemalloc release tarball and build rules. |
Tue, 10 Apr, 14:38 |
| Benno Evers |
Re: Review Request 63368: Added MemoryProfiler class to Libprocess. |
Tue, 10 Apr, 14:39 |
| Benno Evers |
Re: Review Request 63368: Added MemoryProfiler class to Libprocess. |
Tue, 10 Apr, 14:48 |
| Benjamin Bannier |
Re: Review Request 66528: Added logging of failed resource provider registry updates. |
Tue, 10 Apr, 15:05 |
| Benjamin Bannier |
Re: Review Request 66311: Implement recovery of resource provider manager. |
Tue, 10 Apr, 15:27 |
| Mesos Reviewbot Windows |
Re: Review Request 66528: Added logging of failed resource provider registry updates. |
Tue, 10 Apr, 16:17 |
| Mesos Reviewbot Windows |
Re: Review Request 66527: Avoided copy in accessing resource provider subscription field. |
Tue, 10 Apr, 17:35 |
| Greg Mann |
Re: Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods. |
Tue, 10 Apr, 18:15 |
| Greg Mann |
Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type. |
Tue, 10 Apr, 18:28 |
| Greg Mann |
Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`. |
Tue, 10 Apr, 18:30 |
| Greg Mann |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 18:33 |
| Greg Mann |
Re: Review Request 66489: Cleaned up internal evolve functions. |
Tue, 10 Apr, 18:39 |
| Gaston Kleiman |
Re: Review Request 66489: Cleaned up internal evolve functions. |
Tue, 10 Apr, 18:43 |
| Gaston Kleiman |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 18:45 |
| Greg Mann |
Re: Review Request 66462: Added new operation states to be used for status reconciliation. |
Tue, 10 Apr, 18:45 |
| Gaston Kleiman |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 18:45 |
| Andrew Schwartzmeyer |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Tue, 10 Apr, 19:04 |
| Zhitao Li |
Review Request 66531: Added new authorization for `UpdateVolume`. |
Tue, 10 Apr, 19:24 |
| Zhitao Li |
Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`. |
Tue, 10 Apr, 19:24 |
| Mesos Reviewbot Windows |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 19:46 |
| Mesos Reviewbot Windows |
Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`. |
Tue, 10 Apr, 20:39 |
| Benjamin Mahler |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 20:45 |
| Gaston Kleiman |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 20:47 |
| Benjamin Mahler |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 20:50 |
| Mesos Reviewbot |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 20:56 |
| Gaston Kleiman |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 21:04 |
| Greg Mann |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 21:26 |
| Greg Mann |
Re: Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID. |
Tue, 10 Apr, 21:41 |
| Greg Mann |
Re: Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls. |
Tue, 10 Apr, 21:45 |
| Benjamin Mahler |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 21:47 |
| Greg Mann |
Re: Review Request 66465: Updated `using` statements in `tests/mesos.hpp`. |
Tue, 10 Apr, 21:50 |
| Gaston Kleiman |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 21:56 |
| Benjamin Mahler |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Tue, 10 Apr, 22:00 |
| Meng Zhu |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Tue, 10 Apr, 22:54 |
| Meng Zhu |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Tue, 10 Apr, 22:54 |
| Mesos Reviewbot Windows |
Re: Review Request 66468: Added tests for operation status reconciliation. |
Tue, 10 Apr, 23:20 |
| Gilbert Song |
Review Request 66538: Added unit test slave recovery for default executor tests. |
Tue, 10 Apr, 23:41 |
| Gilbert Song |
Review Request 66539: Fixed the agent recovery crash if metadata is missing. |
Tue, 10 Apr, 23:41 |
| Gilbert Song |
Review Request 66540: Added unit test for recovering nested container without slave state. |
Tue, 10 Apr, 23:41 |
| Gilbert Song |
Review Request 66541: Added default executor test for agent recovery without metadata. |
Tue, 10 Apr, 23:41 |
| Jie Yu |
Re: Review Request 66539: Fixed the agent recovery crash if metadata is missing. |
Wed, 11 Apr, 00:09 |
| Benjamin Mahler |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Wed, 11 Apr, 00:28 |
| Mesos Reviewbot Windows |
Re: Review Request 66541: Added default executor test for agent recovery without metadata. |
Wed, 11 Apr, 01:08 |