| John Kordich via Review Board |
Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. |
Wed, 04 Apr, 22:12 |
| John Kordich via Review Board |
Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. |
Wed, 04 Apr, 22:12 |
| John Kordich via Review Board |
Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files. |
Wed, 04 Apr, 22:13 |
| John Kordich via Review Board |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Wed, 04 Apr, 22:16 |
| John Kordich via Review Board |
Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef. |
Wed, 04 Apr, 22:17 |
| John Kordich via Review Board |
Re: Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files. |
Wed, 04 Apr, 22:17 |
| John Kordich via Review Board |
Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. |
Wed, 04 Apr, 22:21 |
| John Kordich via Review Board |
Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace. |
Wed, 04 Apr, 22:22 |
| Andrew Schwartzmeyer |
Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. |
Wed, 04 Apr, 22:24 |
| John Kordich via Review Board |
Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`. |
Wed, 04 Apr, 22:24 |
| Andrew Schwartzmeyer |
Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. |
Wed, 04 Apr, 22:25 |
| John Kordich via Review Board |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 22:28 |
| John Kordich via Review Board |
Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. |
Wed, 04 Apr, 22:31 |
| John Kordich via Review Board |
Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 22:33 |
| Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 22:35 |
| John Kordich via Review Board |
Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`. |
Wed, 04 Apr, 22:35 |
| John Kordich via Review Board |
Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`. |
Wed, 04 Apr, 22:37 |
| John Kordich via Review Board |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Wed, 04 Apr, 22:46 |
| John Kordich via Review Board |
Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 22:53 |
| John Kordich via Review Board |
Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`. |
Wed, 04 Apr, 22:54 |
| Greg Mann |
Re: Review Request 66145: Added a test to verify that task launch order is enforced. |
Wed, 04 Apr, 23:16 |
| Greg Mann |
Re: Review Request 66178: Added a test to verify that task launch order is enforced. |
Wed, 04 Apr, 23:19 |
| Chun-Hung Hsiao |
Review Request 66457: Made resource provider API aware of workloads. |
Wed, 04 Apr, 23:22 |
| Greg Mann |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Wed, 04 Apr, 23:27 |
| Mesos Reviewbot Windows |
Re: Review Request 66457: Made resource provider API aware of workloads. |
Wed, 04 Apr, 23:32 |
| Mesos Reviewbot |
Re: Review Request 66412: Fixed flaky agent test. |
Wed, 04 Apr, 23:46 |
| Gaston Kleiman |
Review Request 66458: Fixed handling of operations in `master::recoverFramework()`. |
Wed, 04 Apr, 23:47 |
| Gaston Kleiman |
Review Request 66459: Fixed bug in `Master::updateSlave()`. |
Wed, 04 Apr, 23:49 |
| Gaston Kleiman |
Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Wed, 04 Apr, 23:53 |
| Gaston Kleiman |
Review Request 66461: Added an evolve function for `v1::scheduler::Response`. |
Wed, 04 Apr, 23:54 |
| Gaston Kleiman |
Review Request 66462: Added new operation states to be used for status reconciliation. |
Wed, 04 Apr, 23:58 |
| Gaston Kleiman |
Review Request 66463: Added a master metric for operations reconciliation messages. |
Wed, 04 Apr, 23:59 |
| Mesos Reviewbot |
Re: Review Request 66457: Made resource provider API aware of workloads. |
Thu, 05 Apr, 00:42 |
| Gaston Kleiman |
Review Request 66464: Implemented operation status reconciliation. |
Thu, 05 Apr, 00:47 |
| Gaston Kleiman |
Review Request 66465: Updated `using` statements in `tests/mesos.hpp`. |
Thu, 05 Apr, 00:48 |
| Gaston Kleiman |
Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID. |
Thu, 05 Apr, 00:49 |
| Gaston Kleiman |
Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls. |
Thu, 05 Apr, 00:50 |
| Mesos Reviewbot Windows |
Re: Review Request 66459: Fixed bug in `Master::updateSlave()`. |
Thu, 05 Apr, 01:09 |
| Andrew Schwartzmeyer |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Thu, 05 Apr, 01:58 |
| Mesos Reviewbot Windows |
Re: Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls. |
Thu, 05 Apr, 02:02 |
| Andrew Schwartzmeyer |
Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`. |
Thu, 05 Apr, 02:06 |
| Mesos Reviewbot |
Re: Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls. |
Thu, 05 Apr, 03:09 |
| Gilbert Song |
Re: Review Request 66454: Updated the documented release schedule. |
Thu, 05 Apr, 04:51 |
| Mesos Reviewbot |
Re: Review Request 66454: Updated the documented release schedule. |
Thu, 05 Apr, 08:46 |
| Benjamin Bannier |
Review Request 66471: Added stringification for resource provider message type. |
Thu, 05 Apr, 08:48 |
| Alexander Rukletsov |
Re: Review Request 66454: Updated the documented release schedule. |
Thu, 05 Apr, 09:43 |
| Mesos Reviewbot Windows |
Re: Review Request 66471: Added stringification for resource provider message type. |
Thu, 05 Apr, 09:44 |
| Benno Evers |
Re: Review Request 65462: Used the new 'route()' overload from libprocess. |
Thu, 05 Apr, 10:28 |
| Mesos Reviewbot |
Re: Review Request 66471: Added stringification for resource provider message type. |
Thu, 05 Apr, 11:13 |
| Andrei Budnik |
Review Request 66474: Updated minimum supported Linux kernel version. |
Thu, 05 Apr, 12:21 |
| Mesos Reviewbot Windows |
Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`. |
Thu, 05 Apr, 13:14 |
| Benjamin Bannier |
Review Request 66476: Tightened resource provider manager registrar tests. |
Thu, 05 Apr, 14:14 |
| Mesos Reviewbot |
Re: Review Request 66474: Updated minimum supported Linux kernel version. |
Thu, 05 Apr, 14:23 |
| Mesos Reviewbot Windows |
Re: Review Request 66474: Updated minimum supported Linux kernel version. |
Thu, 05 Apr, 14:31 |
| Mesos Reviewbot Windows |
Re: Review Request 66476: Tightened resource provider manager registrar tests. |
Thu, 05 Apr, 15:24 |
| Meng Zhu |
Re: Review Request 66347: Added a test for killing executor during task launch. |
Thu, 05 Apr, 16:08 |
| Till Toenshoff |
Re: Review Request 65940: Added test validating hierarchical role accounting. |
Thu, 05 Apr, 16:15 |
| Till Toenshoff |
Re: Review Request 65939: Updated role endpoints for hierarchical accounting. |
Thu, 05 Apr, 16:15 |
| Till Toenshoff |
Re: Review Request 65939: Updated role endpoints for hierarchical accounting. |
Thu, 05 Apr, 16:18 |
| Mesos Reviewbot |
Re: Review Request 66476: Tightened resource provider manager registrar tests. |
Thu, 05 Apr, 16:35 |
| Mesos Reviewbot Windows |
Re: Review Request 65940: Added test validating hierarchical role accounting. |
Thu, 05 Apr, 17:17 |
| John Kordich via Review Board |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Thu, 05 Apr, 17:44 |
| David Forsythe |
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it. |
Thu, 05 Apr, 18:41 |
| David Forsythe |
Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD. |
Thu, 05 Apr, 18:41 |
| David Forsythe |
Re: Review Request 66385: Link execinfo in Glog build on FreeBSD. |
Thu, 05 Apr, 18:41 |
| David Forsythe |
Re: Review Request 66387: Link subversion in stout build on FreeBSD. |
Thu, 05 Apr, 18:42 |
| Meng Zhu |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Thu, 05 Apr, 19:10 |
| Mesos Reviewbot Windows |
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it. |
Thu, 05 Apr, 19:45 |
| Mesos Reviewbot |
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it. |
Thu, 05 Apr, 20:24 |
| Andrew Schwartzmeyer |
Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD. |
Thu, 05 Apr, 20:54 |
| Akash Gupta |
Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. |
Thu, 05 Apr, 20:55 |
| Akash Gupta |
Re: Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess. |
Thu, 05 Apr, 20:55 |
| Akash Gupta |
Re: Review Request 66422: Windows: Included used `jobobject.hpp` stout header in Mesos. |
Thu, 05 Apr, 20:56 |
| Akash Gupta |
Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files. |
Thu, 05 Apr, 20:58 |
| Greg Mann |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Thu, 05 Apr, 21:43 |
| Greg Mann |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Thu, 05 Apr, 22:01 |
| Greg Mann |
Re: Review Request 66347: Added a test for killing executor during task launch. |
Thu, 05 Apr, 22:02 |
| Meng Zhu |
Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. |
Thu, 05 Apr, 22:35 |
| Meng Zhu |
Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. |
Thu, 05 Apr, 22:36 |
| Meng Zhu |
Re: Review Request 66145: Added a test to verify that task launch order is enforced. |
Thu, 05 Apr, 22:38 |
| Meng Zhu |
Re: Review Request 66347: Added a test for killing executor during task launch. |
Thu, 05 Apr, 22:52 |
| Greg Mann |
Re: Review Request 66458: Fixed handling of operations in `master::recoverFramework()`. |
Thu, 05 Apr, 22:52 |
| Akash Gupta |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Thu, 05 Apr, 23:07 |
| Akash Gupta |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Thu, 05 Apr, 23:07 |
| Akash Gupta |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Thu, 05 Apr, 23:07 |
| Akash Gupta |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Thu, 05 Apr, 23:07 |
| Akash Gupta |
Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef. |
Thu, 05 Apr, 23:14 |
| Akash Gupta |
Re: Review Request 66426: Windows: More constness in stout. |
Thu, 05 Apr, 23:15 |
| Akash Gupta |
Re: Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files. |
Thu, 05 Apr, 23:15 |
| Andrew Schwartzmeyer |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Thu, 05 Apr, 23:19 |
| Andrew Schwartzmeyer |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Thu, 05 Apr, 23:21 |
| Akash Gupta |
Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. |
Thu, 05 Apr, 23:25 |
| Zhitao Li |
Review Request 66481: Converted `pid` in command executor to `Option<pid_t>`. |
Thu, 05 Apr, 23:31 |
| Greg Mann |
Re: Review Request 66347: Added a test for killing executor during task launch. |
Thu, 05 Apr, 23:37 |
| Akash Gupta |
Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`. |
Thu, 05 Apr, 23:45 |
| Akash Gupta |
Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace. |
Thu, 05 Apr, 23:46 |
| Akash Gupta |
Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`. |
Thu, 05 Apr, 23:47 |
| Andrew Schwartzmeyer |
Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`. |
Thu, 05 Apr, 23:50 |
| Akash Gupta |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Thu, 05 Apr, 23:51 |
| Akash Gupta |
Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. |
Thu, 05 Apr, 23:52 |