| Kapil Arya |
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. |
Tue, 24 Apr, 06:37 |
| Kapil Arya |
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. |
Tue, 24 Apr, 06:42 |
| Mesos Reviewbot |
Re: Review Request 66608: Improved support for move-only types in `hashmap`. |
Tue, 24 Apr, 07:21 |
| Mesos Reviewbot |
Re: Review Request 66293: Tested default executor support of `max_completion_time`. |
Tue, 24 Apr, 09:53 |
| Benno Evers |
Review Request 66776: Changed failure check for a call to os::system(). |
Tue, 24 Apr, 14:40 |
| Benno Evers |
Re: Review Request 63372: Added documentation for memory profiling. |
Tue, 24 Apr, 14:40 |
| Benno Evers |
Re: Review Request 63372: Added documentation for memory profiling. |
Tue, 24 Apr, 14:42 |
| Benno Evers |
Re: Review Request 66666: Added MemoryProfiler to CHANGELOG. |
Tue, 24 Apr, 16:41 |
| Andrew Schwartzmeyer |
Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`. |
Tue, 24 Apr, 17:12 |
| Benjamin Mahler |
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. |
Tue, 24 Apr, 17:31 |
| Alexander Rukletsov |
Re: Review Request 63372: Added documentation for memory profiling. |
Tue, 24 Apr, 17:59 |
| Alexander Rukletsov |
Re: Review Request 63372: Added documentation for memory profiling. |
Tue, 24 Apr, 17:59 |
| Jiang Yan Xu |
Review Request 66778: Fixed Master which generated updates with the latest task state. |
Tue, 24 Apr, 18:03 |
| Mesos Reviewbot Windows |
Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`. |
Tue, 24 Apr, 18:42 |
| Andrew Schwartzmeyer |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Tue, 24 Apr, 18:55 |
| Benjamin Bannier |
Re: Review Request 66779: Inserted explicit moves in libprocess. |
Tue, 24 Apr, 18:58 |
| Mesos Reviewbot |
Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`. |
Tue, 24 Apr, 19:03 |
| Benjamin Bannier |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Tue, 24 Apr, 19:28 |
| Benjamin Bannier |
Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs. |
Tue, 24 Apr, 19:28 |
| Benjamin Bannier |
Review Request 66780: Removed redundant master flags in resource provider tests. |
Tue, 24 Apr, 19:28 |
| Benjamin Bannier |
Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs. |
Tue, 24 Apr, 19:29 |
| Benjamin Bannier |
Re: Review Request 66545: Added admitted resource providers to the manager's registry. |
Tue, 24 Apr, 19:29 |
| Benjamin Bannier |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Tue, 24 Apr, 19:29 |
| Chun-Hung Hsiao |
Re: Review Request 66545: Added admitted resource providers to the manager's registry. |
Tue, 24 Apr, 19:42 |
| Andrew Schwartzmeyer |
Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`. |
Tue, 24 Apr, 20:41 |
| Andrew Schwartzmeyer |
Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`. |
Tue, 24 Apr, 20:42 |
| Joseph Wu |
Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`. |
Tue, 24 Apr, 21:16 |
| Zhitao Li |
Re: Review Request 66733: Added a new `RESIZE_VOLUME` agent capability. |
Tue, 24 Apr, 21:16 |
| Zhitao Li |
Re: Review Request 66050: Implemented grow and shrink of persistent volumes. |
Tue, 24 Apr, 21:16 |
| Mesos Reviewbot |
Re: Review Request 66778: Fixed Master which generated updates with the latest task state. |
Tue, 24 Apr, 21:21 |
| Mesos Reviewbot Windows |
Re: Review Request 66778: Fixed Master which generated updates with the latest task state. |
Tue, 24 Apr, 22:02 |
| Joseph Wu |
Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`. |
Tue, 24 Apr, 22:09 |
| Chun-Hung Hsiao |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Tue, 24 Apr, 22:27 |
| Chun-Hung Hsiao |
Re: Review Request 66780: Removed redundant master flags in resource provider tests. |
Tue, 24 Apr, 22:30 |
| Chun-Hung Hsiao |
Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs. |
Tue, 24 Apr, 22:31 |
| Chun-Hung Hsiao |
Re: Review Request 66545: Added admitted resource providers to the manager's registry. |
Tue, 24 Apr, 22:40 |
| Joseph Wu |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Tue, 24 Apr, 22:55 |
| Mesos Reviewbot Windows |
Re: Review Request 66780: Removed redundant master flags in resource provider tests. |
Tue, 24 Apr, 23:09 |
| Chun-Hung Hsiao |
Re: Review Request 66309: Externalized creation of resource provider manager backing storage. |
Tue, 24 Apr, 23:14 |
| Andrew Schwartzmeyer |
Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite. |
Tue, 24 Apr, 23:18 |
| James Peach |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Tue, 24 Apr, 23:38 |
| James Peach |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Tue, 24 Apr, 23:38 |
| Chun-Hung Hsiao |
Re: Review Request 66545: Added admitted resource providers to the manager's registry. |
Tue, 24 Apr, 23:50 |
| Chun-Hung Hsiao |
Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs. |
Tue, 24 Apr, 23:51 |
| Chun-Hung Hsiao |
Re: Review Request 66733: Added a new `RESIZE_VOLUME` agent capability. |
Wed, 25 Apr, 00:05 |
| Mesos Reviewbot Windows |
Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite. |
Wed, 25 Apr, 02:42 |
| Mesos Reviewbot |
Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite. |
Wed, 25 Apr, 03:48 |
| Chun-Hung Hsiao |
Re: Review Request 66050: Implemented grow and shrink of persistent volumes. |
Wed, 25 Apr, 04:05 |
| Chun-Hung Hsiao |
Re: Review Request 66050: Implemented grow and shrink of persistent volumes. |
Wed, 25 Apr, 04:06 |
| Chun-Hung Hsiao |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 04:13 |
| Chun-Hung Hsiao |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 04:22 |
| Chun-Hung Hsiao |
Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. |
Wed, 25 Apr, 04:28 |
| Andrew Schwartzmeyer |
Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`. |
Wed, 25 Apr, 05:28 |
| Chun-Hung Hsiao |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 05:33 |
| Zhitao Li |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 06:03 |
| Zhitao Li |
Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`. |
Wed, 25 Apr, 06:16 |
| Zhitao Li |
Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`. |
Wed, 25 Apr, 06:18 |
| Chun-Hung Hsiao |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 06:24 |
| Alexander Rukletsov |
Re: Review Request 66779: Inserted explicit moves in libprocess. |
Wed, 25 Apr, 08:48 |
| Benjamin Bannier |
Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs. |
Wed, 25 Apr, 10:55 |
| Benjamin Bannier |
Re: Review Request 66545: Added admitted resource providers to the manager's registry. |
Wed, 25 Apr, 10:56 |
| Benjamin Bannier |
Re: Review Request 66526: Renamed resource provider `AgentRegistrar` to `GenericRegistrar`. |
Wed, 25 Apr, 10:56 |
| Mesos Reviewbot Windows |
Re: Review Request 66780: Removed redundant master flags in resource provider tests. |
Wed, 25 Apr, 11:03 |
| Andrei Budnik |
Re: Review Request 66769: Fixed flaky ReconciliationTest.ReconcileStatusUpdateTaskState. |
Wed, 25 Apr, 12:49 |
| Benno Evers |
Re: Review Request 63372: Added documentation for memory profiling. |
Wed, 25 Apr, 14:07 |
| Benno Evers |
Re: Review Request 63372: Added documentation for memory profiling. |
Wed, 25 Apr, 14:09 |
| Mesos Reviewbot Windows |
Re: Review Request 66776: Changed failure check for a call to os::system(). |
Wed, 25 Apr, 15:24 |
| Zhitao Li |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 15:51 |
| Greg Mann |
Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. |
Wed, 25 Apr, 16:09 |
| James Peach |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Wed, 25 Apr, 16:17 |
| Chun-Hung Hsiao |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 16:31 |
| Zhitao Li |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 16:37 |
| James Peach |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Wed, 25 Apr, 16:44 |
| Mesos Reviewbot Windows |
Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters. |
Wed, 25 Apr, 16:45 |
| Benno Evers |
Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'. |
Wed, 25 Apr, 16:46 |
| Chun-Hung Hsiao |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 16:52 |
| Megha Sharma |
Re: Review Request 66769: Fixed flaky ReconciliationTest.ReconcileStatusUpdateTaskState. |
Wed, 25 Apr, 16:58 |
| Chun-Hung Hsiao |
Re: Review Request 66568: Dropped combined operations with GROW and SHRINK volumes. |
Wed, 25 Apr, 17:19 |
| Mesos Reviewbot |
Re: Review Request 66776: Changed failure check for a call to os::system(). |
Wed, 25 Apr, 17:24 |
| Mesos Reviewbot |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Wed, 25 Apr, 19:55 |
| Mesos Reviewbot Windows |
Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'. |
Wed, 25 Apr, 20:13 |
| Chun-Hung Hsiao |
Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. |
Wed, 25 Apr, 23:58 |
| Chun-Hung Hsiao |
Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. |
Wed, 25 Apr, 23:59 |
| Chun-Hung Hsiao |
Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. |
Wed, 25 Apr, 23:59 |
| Chun-Hung Hsiao |
Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations. |
Wed, 25 Apr, 23:59 |
| Mesos Reviewbot |
Re: Review Request 66780: Removed redundant master flags in resource provider tests. |
Thu, 26 Apr, 02:46 |
| Mesos Reviewbot Windows |
Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters. |
Thu, 26 Apr, 07:41 |
| Mesos Reviewbot |
Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'. |
Thu, 26 Apr, 08:43 |
| Alexander Rukletsov |
Re: Review Request 63372: Added documentation for memory profiling. |
Thu, 26 Apr, 09:54 |
| Benno Evers |
Review Request 66405: Doc improvements (wip). |
Thu, 26 Apr, 09:59 |
| Benno Evers |
Re: Review Request 63371: Added unit test for new MemoryProfiler class. |
Thu, 26 Apr, 09:59 |
| Alexander Rukletsov |
Re: Review Request 63372: Added documentation for memory profiling. |
Thu, 26 Apr, 10:06 |
| Alexander Rukletsov |
Re: Review Request 63372: Added documentation for memory profiling. |
Thu, 26 Apr, 10:36 |
| Mesos Reviewbot Windows |
Re: Review Request 63371: Added unit test for new MemoryProfiler class. |
Thu, 26 Apr, 10:56 |
| Mesos Reviewbot |
Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters. |
Thu, 26 Apr, 11:00 |
| Benjamin Bannier |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Thu, 26 Apr, 12:39 |
| Benjamin Bannier |
Re: Review Request 66310: Passed on registrar when constructing resource provider manager. |
Thu, 26 Apr, 12:39 |
| Mesos Reviewbot Windows |
Re: Review Request 63372: Added documentation for memory profiling. |
Thu, 26 Apr, 12:58 |
| Qian Zhang |
Review Request 66811: Added `libacl` as a dependency of stout. |
Thu, 26 Apr, 14:03 |
| Qian Zhang |
Review Request 66812: Added `libacl` as a dependency of Mesos. |
Thu, 26 Apr, 14:04 |