| Chun-Hung Hsiao |
Re: Review Request 66411: Made the test CSI plugin compatible to CSI v0.2. |
Wed, 04 Apr, 04:00 |
| Chun-Hung Hsiao |
Review Request 66418: Handled failed publish and unpublish CSI calls properly. |
Wed, 04 Apr, 04:01 |
| David Forsythe |
Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD. |
Wed, 04 Apr, 04:42 |
| Mesos Reviewbot Windows |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Wed, 04 Apr, 04:49 |
| Mesos Reviewbot Windows |
Re: Review Request 66418: Handled failed publish and unpublish CSI calls properly. |
Wed, 04 Apr, 04:50 |
| Mesos Reviewbot |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Wed, 04 Apr, 05:01 |
| Mesos Reviewbot Windows |
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it. |
Wed, 04 Apr, 05:42 |
| Andrew Schwartzmeyer |
Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. |
Wed, 04 Apr, 05:46 |
| Andrew Schwartzmeyer |
Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess. |
Wed, 04 Apr, 05:47 |
| Andrew Schwartzmeyer |
Review Request 66422: Windows: Included used `jobobject.hpp` stout header in Mesos. |
Wed, 04 Apr, 05:47 |
| Andrew Schwartzmeyer |
Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files. |
Wed, 04 Apr, 05:47 |
| Andrew Schwartzmeyer |
Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Wed, 04 Apr, 05:47 |
| Andrew Schwartzmeyer |
Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef. |
Wed, 04 Apr, 05:47 |
| Andrew Schwartzmeyer |
Review Request 66426: Windows: More constness in stout. |
Wed, 04 Apr, 05:48 |
| Andrew Schwartzmeyer |
Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files. |
Wed, 04 Apr, 05:48 |
| Gilbert Song |
Re: Review Request 66038: Add usageWithInode to check both disk and inode usage. |
Wed, 04 Apr, 05:48 |
| Andrew Schwartzmeyer |
Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. |
Wed, 04 Apr, 05:49 |
| Andrew Schwartzmeyer |
Review Request 66429: Windows: Deleted dead code from `process::internal` namespace. |
Wed, 04 Apr, 05:49 |
| Andrew Schwartzmeyer |
Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`. |
Wed, 04 Apr, 05:50 |
| Andrew Schwartzmeyer |
Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 05:50 |
| Gilbert Song |
Re: Review Request 66039: Check both disk and inode usage when slaves schedule gc. |
Wed, 04 Apr, 05:50 |
| Andrew Schwartzmeyer |
Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. |
Wed, 04 Apr, 05:50 |
| Andrew Schwartzmeyer |
Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 05:51 |
| Andrew Schwartzmeyer |
Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`. |
Wed, 04 Apr, 05:51 |
| Andrew Schwartzmeyer |
Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`. |
Wed, 04 Apr, 05:52 |
| Andrew Schwartzmeyer |
Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`. |
Wed, 04 Apr, 05:54 |
| Andrew Schwartzmeyer |
Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Wed, 04 Apr, 05:55 |
| Andrew Schwartzmeyer |
Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly. |
Wed, 04 Apr, 05:56 |
| Andrew Schwartzmeyer |
Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 05:56 |
| Andrew Schwartzmeyer |
Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Wed, 04 Apr, 05:57 |
| Andrew Schwartzmeyer |
Review Request 66441: Fixed mismatched types in `process.cpp`. |
Wed, 04 Apr, 05:57 |
| Andrew Schwartzmeyer |
Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`. |
Wed, 04 Apr, 05:57 |
| Andrew Schwartzmeyer |
Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`. |
Wed, 04 Apr, 05:58 |
| Andrew Schwartzmeyer |
Review Request 66444: Windows: Made `signals.hpp` compile. |
Wed, 04 Apr, 05:58 |
| Andrew Schwartzmeyer |
Review Request 66445: Windows: Cleaned up included CRT headers. |
Wed, 04 Apr, 05:58 |
| Andrew Schwartzmeyer |
Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 06:00 |
| Mesos Reviewbot Windows |
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. |
Wed, 04 Apr, 06:06 |
| Benjamin Bannier |
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. |
Wed, 04 Apr, 06:27 |
| Mesos Reviewbot Windows |
Re: Review Request 66412: Fixed flaky agent test. |
Wed, 04 Apr, 06:37 |
| David Forsythe |
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. |
Wed, 04 Apr, 06:45 |
| David Forsythe |
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. |
Wed, 04 Apr, 06:46 |
| Mesos Reviewbot |
Re: Review Request 66445: Windows: Cleaned up included CRT headers. |
Wed, 04 Apr, 07:26 |
| Mesos Reviewbot Windows |
Re: Review Request 66445: Windows: Cleaned up included CRT headers. |
Wed, 04 Apr, 07:31 |
| Mesos Reviewbot Windows |
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. |
Wed, 04 Apr, 08:24 |
| Mesos Reviewbot |
Re: Review Request 66412: Fixed flaky agent test. |
Wed, 04 Apr, 09:42 |
| Mesos Reviewbot |
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. |
Wed, 04 Apr, 12:11 |
| Benjamin Bannier |
Re: Review Request 66165: Re-fixed many master allocator tests. |
Wed, 04 Apr, 12:13 |
| Andrei Budnik |
Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test. |
Wed, 04 Apr, 12:17 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Wed, 04 Apr, 12:21 |
| Benjamin Bannier |
Review Request 66450: Added missing gmock expectation. |
Wed, 04 Apr, 12:21 |
| Benjamin Bannier |
Review Request 66451: Added devolve function for 'ResourceProviderInfo'. |
Wed, 04 Apr, 12:35 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Wed, 04 Apr, 13:04 |
| Mesos Reviewbot Windows |
Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test. |
Wed, 04 Apr, 13:15 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Wed, 04 Apr, 13:28 |
| Mesos Reviewbot Windows |
Re: Review Request 66450: Added missing gmock expectation. |
Wed, 04 Apr, 14:08 |
| Mesos Reviewbot Windows |
Re: Review Request 66451: Added devolve function for 'ResourceProviderInfo'. |
Wed, 04 Apr, 14:33 |
| David Forsythe |
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. |
Wed, 04 Apr, 14:34 |
| Mesos Reviewbot |
Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test. |
Wed, 04 Apr, 14:36 |
| Andrei Budnik |
Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`. |
Wed, 04 Apr, 14:44 |
| Mesos Reviewbot Windows |
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. |
Wed, 04 Apr, 15:34 |
| Mesos Reviewbot |
Re: Review Request 66450: Added missing gmock expectation. |
Wed, 04 Apr, 16:43 |
| Andrew Schwartzmeyer |
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it. |
Wed, 04 Apr, 17:04 |
| Andrew Schwartzmeyer |
Re: Review Request 66444: Windows: Made `signals.hpp` compile. |
Wed, 04 Apr, 17:22 |
| Andrew Schwartzmeyer |
Re: Review Request 66441: Fixed mismatched types in `process.cpp`. |
Wed, 04 Apr, 17:29 |
| Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 17:31 |
| Harold Dost |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Wed, 04 Apr, 17:41 |
| Harold Dost |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Wed, 04 Apr, 17:41 |
| Ilya Pronin |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Wed, 04 Apr, 18:06 |
| Gilbert Song |
Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test. |
Wed, 04 Apr, 18:23 |
| Greg Mann |
Review Request 66454: Updated the documented release schedule. |
Wed, 04 Apr, 18:48 |
| Mesos Reviewbot |
Re: Review Request 66451: Added devolve function for 'ResourceProviderInfo'. |
Wed, 04 Apr, 18:54 |
| Mesos Reviewbot Windows |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Wed, 04 Apr, 19:07 |
| Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 19:13 |
| Andrew Schwartzmeyer |
Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`. |
Wed, 04 Apr, 19:15 |
| Andrew Schwartzmeyer |
Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace. |
Wed, 04 Apr, 19:17 |
| Andrew Schwartzmeyer |
Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`. |
Wed, 04 Apr, 19:18 |
| Andrew Schwartzmeyer |
Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 19:18 |
| Andrew Schwartzmeyer |
Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly. |
Wed, 04 Apr, 19:19 |
| Meng Zhu |
Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. |
Wed, 04 Apr, 19:20 |
| Meng Zhu |
Re: Review Request 66412: Fixed flaky agent test. |
Wed, 04 Apr, 19:23 |
| Andrew Schwartzmeyer |
Re: Review Request 66445: Windows: Cleaned up included CRT headers. |
Wed, 04 Apr, 19:26 |
| Mesos Reviewbot Windows |
Re: Review Request 66454: Updated the documented release schedule. |
Wed, 04 Apr, 19:59 |
| Mesos Reviewbot Windows |
Re: Review Request 66412: Fixed flaky agent test. |
Wed, 04 Apr, 20:01 |
| Andrei Budnik |
Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test. |
Wed, 04 Apr, 20:05 |
| Gilbert Song |
Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test. |
Wed, 04 Apr, 20:26 |
| Gilbert Song |
Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test. |
Wed, 04 Apr, 20:26 |
| John Kordich via Review Board |
Re: Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess. |
Wed, 04 Apr, 21:15 |
| John Kordich via Review Board |
Re: Review Request 66422: Windows: Included used `jobobject.hpp` stout header in Mesos. |
Wed, 04 Apr, 21:16 |
| John Kordich via Review Board |
Re: Review Request 66426: Windows: More constness in stout. |
Wed, 04 Apr, 21:17 |
| John Kordich via Review Board |
Re: Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`. |
Wed, 04 Apr, 21:19 |
| John Kordich via Review Board |
Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly. |
Wed, 04 Apr, 21:20 |
| John Kordich via Review Board |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Wed, 04 Apr, 21:21 |
| John Kordich via Review Board |
Re: Review Request 66441: Fixed mismatched types in `process.cpp`. |
Wed, 04 Apr, 21:21 |
| John Kordich via Review Board |
Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`. |
Wed, 04 Apr, 21:22 |
| John Kordich via Review Board |
Re: Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`. |
Wed, 04 Apr, 21:22 |
| John Kordich via Review Board |
Re: Review Request 66444: Windows: Made `signals.hpp` compile. |
Wed, 04 Apr, 21:23 |
| John Kordich via Review Board |
Re: Review Request 66445: Windows: Cleaned up included CRT headers. |
Wed, 04 Apr, 21:23 |
| Andrew Schwartzmeyer |
Re: Review Request 66441: Fixed mismatched types in `process.cpp`. |
Wed, 04 Apr, 21:43 |
| Mesos Reviewbot Windows |
Re: Review Request 66412: Fixed flaky agent test. |
Wed, 04 Apr, 21:45 |
| Andrew Schwartzmeyer |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Wed, 04 Apr, 21:49 |