| John Kordich via Review Board |
Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`. |
Fri, 27 Apr, 19:06 |
| John Kordich via Review Board |
Re: Review Request 66834: Windows: Specialized `flags::parse<int_fd>`. |
Fri, 27 Apr, 19:07 |
| John Kordich via Review Board |
Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`. |
Fri, 27 Apr, 19:07 |
| John Kordich via Review Board |
Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`. |
Fri, 27 Apr, 19:08 |
| Joseph Wu |
Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files. |
Wed, 18 Apr, 18:09 |
| Joseph Wu |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Wed, 18 Apr, 18:09 |
| Joseph Wu |
Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef. |
Wed, 18 Apr, 18:09 |
| Joseph Wu |
Re: Review Request 66426: Windows: More constness in stout. |
Wed, 18 Apr, 18:10 |
| Joseph Wu |
Re: Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files. |
Wed, 18 Apr, 18:10 |
| Joseph Wu |
Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. |
Wed, 18 Apr, 18:10 |
| Joseph Wu |
Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `FileEndOfFileInfo`. |
Wed, 18 Apr, 18:10 |
| Joseph Wu |
Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace. |
Wed, 18 Apr, 18:10 |
| Joseph Wu |
Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`. |
Wed, 18 Apr, 18:10 |
| Joseph Wu |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 18 Apr, 18:55 |
| Joseph Wu |
Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. |
Wed, 18 Apr, 19:34 |
| Joseph Wu |
Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`. |
Wed, 18 Apr, 20:07 |
| Joseph Wu |
Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`. |
Wed, 18 Apr, 21:12 |
| Joseph Wu |
Re: Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`. |
Wed, 18 Apr, 21:14 |
| Joseph Wu |
Re: Review Request 66709: Windows: Fixed Ninja in Release configuration. |
Thu, 19 Apr, 01:21 |
| Joseph Wu |
Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. |
Thu, 19 Apr, 20:43 |
| Joseph Wu |
Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly. |
Thu, 19 Apr, 20:52 |
| Joseph Wu |
Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly. |
Thu, 19 Apr, 21:07 |
| Joseph Wu |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Thu, 19 Apr, 22:32 |
| Joseph Wu |
Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`. |
Mon, 23 Apr, 21:20 |
| Joseph Wu |
Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`. |
Mon, 23 Apr, 22:15 |
| Joseph Wu |
Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly. |
Mon, 23 Apr, 22:16 |
| Joseph Wu |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Mon, 23 Apr, 22:28 |
| Joseph Wu |
Re: Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`. |
Mon, 23 Apr, 22:54 |
| Joseph Wu |
Re: Review Request 66444: Windows: Made `signals.hpp` compile. |
Mon, 23 Apr, 23:13 |
| Joseph Wu |
Re: Review Request 66445: Windows: Cleaned up included CRT headers. |
Mon, 23 Apr, 23:57 |
| Joseph Wu |
Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`. |
Tue, 24 Apr, 21:16 |
| Joseph Wu |
Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`. |
Tue, 24 Apr, 22:09 |
| Joseph Wu |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Tue, 24 Apr, 22:55 |
| Kapil Arya |
Re: Review Request 65939: Updated role endpoints for hierarchical accounting. |
Fri, 06 Apr, 00:25 |
| Kapil Arya |
Re: Review Request 65940: Added test validating hierarchical role accounting. |
Fri, 06 Apr, 00:25 |
| Kapil Arya |
Re: Review Request 66228: Added Call for updating framework info. |
Wed, 11 Apr, 17:28 |
| Kapil Arya |
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call. |
Wed, 11 Apr, 17:28 |
| Kapil Arya |
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call. |
Fri, 13 Apr, 01:38 |
| Kapil Arya |
Re: Review Request 66230: Added test for adding/removing framework roles. |
Fri, 13 Apr, 01:38 |
| Kapil Arya |
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call. |
Fri, 13 Apr, 01:39 |
| Kapil Arya |
Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. |
Fri, 20 Apr, 20:19 |
| Kapil Arya |
Re: Review Request 66228: Added Call for updating framework info. |
Fri, 20 Apr, 20:19 |
| Kapil Arya |
Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call. |
Fri, 20 Apr, 20:19 |
| Kapil Arya |
Re: Review Request 66230: Added test for adding/removing framework roles. |
Fri, 20 Apr, 20:19 |
| Kapil Arya |
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. |
Tue, 24 Apr, 06:37 |
| Kapil Arya |
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. |
Tue, 24 Apr, 06:42 |
| Kapil Arya |
Review Request 66864: Updated FrameworkInfo comparator. |
Sun, 29 Apr, 03:36 |
| Kapil Arya |
Review Request 66872: Updated FrameworkInfo comparator. |
Mon, 30 Apr, 21:13 |
| Kevin Klues |
Re: Review Request 65585: Improved documentation regarding the new CLI setup. |
Thu, 12 Apr, 12:21 |
| Kevin Klues |
Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths. |
Thu, 12 Apr, 12:23 |
| Kevin Klues |
Re: Review Request 64211: Added options to build the Python CLI and run unit tests. |
Thu, 12 Apr, 12:24 |
| Kevin Klues |
Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths. |
Thu, 12 Apr, 12:24 |
| Kevin Klues |
Re: Review Request 65585: Improved documentation regarding the new CLI setup. |
Thu, 12 Apr, 12:31 |
| Kevin Klues |
Re: Review Request 65585: Improved documentation regarding the new CLI setup. |
Thu, 12 Apr, 12:39 |
| Kevin Klues |
Re: Review Request 64211: Added options to build the Python CLI and run unit tests. |
Thu, 12 Apr, 13:35 |
| Megha Sharma |
Review Request 66644: Remove unknown unreachable tasks when agent re-registers. |
Mon, 23 Apr, 18:11 |
| Megha Sharma |
Re: Review Request 66769: Fixed flaky ReconciliationTest.ReconcileStatusUpdateTaskState. |
Wed, 25 Apr, 16:58 |
| Megha Sharma |
Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters. |
Fri, 27 Apr, 18:28 |
| Meng Zhu |
Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. |
Mon, 02 Apr, 17:57 |
| Meng Zhu |
Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Mon, 02 Apr, 17:59 |
| Meng Zhu |
Re: Review Request 66144: Enforced task launch order on the agent. |
Mon, 02 Apr, 18:04 |
| Meng Zhu |
Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. |
Tue, 03 Apr, 00:33 |
| Meng Zhu |
Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. |
Tue, 03 Apr, 00:33 |
| Meng Zhu |
Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Tue, 03 Apr, 00:35 |
| Meng Zhu |
Re: Review Request 66322: Fixed a potential race in `Sequence`. |
Tue, 03 Apr, 00:35 |
| Meng Zhu |
Re: Review Request 66144: Enforced task launch order on the agent. |
Tue, 03 Apr, 00:36 |
| Meng Zhu |
Re: Review Request 66144: Enforced task launch order on the agent. |
Tue, 03 Apr, 00:36 |
| Meng Zhu |
Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. |
Tue, 03 Apr, 17:37 |
| Meng Zhu |
Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Tue, 03 Apr, 17:38 |
| Meng Zhu |
Re: Review Request 66143: Refactored agent task launch for better composition [2/2]. |
Tue, 03 Apr, 17:38 |
| Meng Zhu |
Re: Review Request 66144: Enforced task launch order on the agent. |
Tue, 03 Apr, 17:39 |
| Meng Zhu |
Re: Review Request 66145: Added a test to verify that task launch order is enforced. |
Tue, 03 Apr, 19:05 |
| Meng Zhu |
Re: Review Request 66178: Added a test to verify that task launch order is enforced. |
Tue, 03 Apr, 19:07 |
| Meng Zhu |
Re: Review Request 66145: Added a test to verify that task launch order is enforced. |
Tue, 03 Apr, 22:08 |
| Meng Zhu |
Review Request 66412: Fixed flaky agent test. |
Tue, 03 Apr, 22:10 |
| Meng Zhu |
Re: Review Request 66346: Added three matchers for agent tests. |
Wed, 04 Apr, 03:21 |
| Meng Zhu |
Re: Review Request 66178: Added a test to verify that task launch order is enforced. |
Wed, 04 Apr, 03:24 |
| Meng Zhu |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Wed, 04 Apr, 03:32 |
| Meng Zhu |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Wed, 04 Apr, 03:36 |
| Meng Zhu |
Re: Review Request 66347: Added a test for killing executor during task launch. |
Wed, 04 Apr, 03:38 |
| Meng Zhu |
Re: Review Request 66347: Added a test for killing executor during task launch. |
Wed, 04 Apr, 03:39 |
| Meng Zhu |
Re: Review Request 66412: Fixed flaky agent test. |
Wed, 04 Apr, 03:41 |
| Meng Zhu |
Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. |
Wed, 04 Apr, 19:20 |
| Meng Zhu |
Re: Review Request 66412: Fixed flaky agent test. |
Wed, 04 Apr, 19:23 |
| Meng Zhu |
Re: Review Request 66347: Added a test for killing executor during task launch. |
Thu, 05 Apr, 16:08 |
| Meng Zhu |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Thu, 05 Apr, 19:10 |
| Meng Zhu |
Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations. |
Thu, 05 Apr, 22:35 |
| Meng Zhu |
Re: Review Request 66126: Refactored agent task launch for better composition [1/2]. |
Thu, 05 Apr, 22:36 |
| Meng Zhu |
Re: Review Request 66145: Added a test to verify that task launch order is enforced. |
Thu, 05 Apr, 22:38 |
| Meng Zhu |
Re: Review Request 66347: Added a test for killing executor during task launch. |
Thu, 05 Apr, 22:52 |
| Meng Zhu |
Re: Review Request 66145: Added a test to verify that task launch order is enforced. |
Fri, 06 Apr, 00:35 |
| Meng Zhu |
Re: Review Request 66178: Added a test to verify that task launch order is enforced. |
Fri, 06 Apr, 00:35 |
| Meng Zhu |
Re: Review Request 66323: Added tests for failed task launch on agent. |
Fri, 06 Apr, 00:36 |
| Meng Zhu |
Re: Review Request 66347: Added a test for killing executor during task launch. |
Fri, 06 Apr, 00:37 |
| Meng Zhu |
Re: Review Request 65819: Enforced quota limit in the first resource allocation stage. |
Sat, 07 Apr, 00:42 |
| Meng Zhu |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Tue, 10 Apr, 22:54 |
| Meng Zhu |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Tue, 10 Apr, 22:54 |
| Meng Zhu |
Re: Review Request 65334: Added quota limit to the master API protos. |
Wed, 11 Apr, 16:25 |
| Meng Zhu |
Review Request 66692: Fixed an documentation error in `monitoring.md`. |
Wed, 18 Apr, 17:37 |
| Meng Zhu |
Review Request 66725: Improved error message in the fetcher. |
Thu, 19 Apr, 23:08 |