| James Peach |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Wed, 11 Apr, 20:57 |
| James Peach |
Re: Review Request 66259: Added `max_completion_time` support to command executor. |
Fri, 13 Apr, 17:23 |
| James Peach |
Re: Review Request 66591: Added a validation that `max_completion_time` must be non-negative. |
Fri, 13 Apr, 17:24 |
| James Peach |
Re: Review Request 66258: Added `max_completion_time` to `TaskInfo` and new reason. |
Fri, 13 Apr, 17:57 |
| James Peach |
Re: Review Request 66260: Tested `max_completion_time` support in command executor. |
Fri, 13 Apr, 18:31 |
| James Peach |
Re: Review Request 66283: Added support of `max_completion_time` in docker executor. |
Fri, 13 Apr, 20:10 |
| James Peach |
Re: Review Request 66284: Tested `max_completion_time` support in docker executor. |
Fri, 13 Apr, 23:55 |
| James Peach |
Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests. |
Fri, 13 Apr, 23:57 |
| James Peach |
Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests. |
Mon, 16 Apr, 16:50 |
| James Peach |
Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests. |
Mon, 16 Apr, 16:51 |
| James Peach |
Review Request 66637: Added a `createDockerInfo` helper API in Docker containerizer tests. |
Mon, 16 Apr, 16:52 |
| James Peach |
Re: Review Request 66637: Added a `createDockerInfo` helper API in Docker containerizer tests. |
Mon, 16 Apr, 17:31 |
| James Peach |
Re: Review Request 53267: Added a gauge to track active subscribers. |
Mon, 16 Apr, 20:36 |
| James Peach |
Review Request 66704: Refactored the executor launch path. |
Wed, 18 Apr, 22:11 |
| James Peach |
Review Request 66705: Propagated executor sandbox creation errors. |
Wed, 18 Apr, 22:12 |
| James Peach |
Review Request 66706: Handled failing to create the executor sandbox. |
Wed, 18 Apr, 22:12 |
| James Peach |
Review Request 66707: Added a test for launching a task as an unknown user. |
Wed, 18 Apr, 22:12 |
| James Peach |
Review Request 66708: Refactored sending a TASK_DROPPED status update. |
Wed, 18 Apr, 22:13 |
| James Peach |
Re: Review Request 66694: Updated the 1.6.0 CHANGELOG. |
Thu, 19 Apr, 16:52 |
| James Peach |
Re: Review Request 66704: Refactored the executor launch path. |
Thu, 19 Apr, 17:52 |
| James Peach |
Re: Review Request 66705: Propagated executor sandbox creation errors. |
Thu, 19 Apr, 17:52 |
| James Peach |
Re: Review Request 66705: Propagated executor sandbox creation errors. |
Thu, 19 Apr, 17:52 |
| James Peach |
Re: Review Request 66706: Handled failing to create the executor sandbox. |
Thu, 19 Apr, 17:54 |
| James Peach |
Re: Review Request 66706: Handled failing to create the executor sandbox. |
Thu, 19 Apr, 17:54 |
| James Peach |
Re: Review Request 66707: Added a test for launching a task as an unknown user. |
Thu, 19 Apr, 17:56 |
| James Peach |
Re: Review Request 66708: Refactored sending a TASK_DROPPED status update. |
Thu, 19 Apr, 18:09 |
| James Peach |
Re: Review Request 66708: Refactored sending a TASK_DROPPED status update. |
Thu, 19 Apr, 18:09 |
| James Peach |
Re: Review Request 62472: Fixed the ordering of Mesos containerizer isolators. |
Thu, 19 Apr, 21:22 |
| James Peach |
Re: Review Request 66759: Fixed a regression in isolator ordering. |
Mon, 23 Apr, 15:26 |
| James Peach |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Tue, 24 Apr, 23:38 |
| James Peach |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Tue, 24 Apr, 23:38 |
| James Peach |
Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs. |
Wed, 25 Apr, 16:17 |
| James Peach |
Re: Review Request 66173: Add test for new `disk/xfs` kill functionality. |
Wed, 25 Apr, 16:44 |
| James Peach |
Re: Review Request 66293: Tested default executor support of `max_completion_time`. |
Mon, 30 Apr, 23:21 |
| James Peach |
Re: Review Request 66291: Added support to `max_completion_time` in default executor. |
Mon, 30 Apr, 23:27 |
| James Peach |
Re: Review Request 66284: Tested `max_completion_time` support in docker executor. |
Mon, 30 Apr, 23:27 |
| James Peach |
Re: Review Request 66283: Added support of `max_completion_time` in docker executor. |
Mon, 30 Apr, 23:32 |
| James Peach |
Re: Review Request 66259: Added `max_completion_time` support to command executor. |
Mon, 30 Apr, 23:33 |
| Jan Schlicht |
Re: Review Request 66450: Added missing gmock expectation. |
Mon, 09 Apr, 10:27 |
| Jan Schlicht |
Re: Review Request 66476: Tightened resource provider manager registrar tests. |
Mon, 09 Apr, 10:37 |
| Jan Schlicht |
Re: Review Request 66451: Added devolve function for 'ResourceProviderInfo'. |
Mon, 09 Apr, 11:34 |
| Jan Schlicht |
Re: Review Request 66471: Added stringification for resource provider message type. |
Mon, 09 Apr, 11:35 |
| Jan Schlicht |
Re: Review Request 66311: Implement recovery of resource provider manager. |
Tue, 10 Apr, 13:05 |
| Jan Schlicht |
Re: Review Request 66508: Made sure test agent has reached stable state before starting test. |
Tue, 10 Apr, 14:15 |
| Jan Schlicht |
Re: Review Request 66527: Avoided copy in accessing resource provider subscription field. |
Tue, 10 Apr, 14:18 |
| Jan Schlicht |
Re: Review Request 66528: Added logging of failed resource provider registry updates. |
Tue, 10 Apr, 14:20 |
| Jan Schlicht |
Re: Review Request 66545: Added admitted resource providers to the manager's registry. |
Wed, 11 Apr, 12:47 |
| Jan Schlicht |
Re: Review Request 66621: Add alg RS256 support for JWT generator and validator. |
Mon, 16 Apr, 10:02 |
| Jan Schlicht |
Review Request 66759: Fixed a regression in isolator ordering. |
Mon, 23 Apr, 09:55 |
| Jiang Yan Xu |
Review Request 66769: Fixed flaky ReconciliationTest.ReconcileStatusUpdateTaskState. |
Mon, 23 Apr, 22:23 |
| Jiang Yan Xu |
Review Request 66778: Fixed Master which generated updates with the latest task state. |
Tue, 24 Apr, 18:03 |
| Jie Yu |
Re: Review Request 66454: Updated the documented release schedule. |
Fri, 06 Apr, 15:18 |
| Jie Yu |
Re: Review Request 66539: Fixed the agent recovery crash if metadata is missing. |
Wed, 11 Apr, 00:09 |
| Jie Yu |
Re: Review Request 66398: Bumped the CSI spec bundle to 0.2.0. |
Thu, 12 Apr, 16:39 |
| Jie Yu |
Re: Review Request 66407: Updated CSI client to support v0.2. |
Thu, 12 Apr, 16:46 |
| Jie Yu |
Re: Review Request 66408: Updated CSI helpers for v0.2. |
Thu, 12 Apr, 16:48 |
| Jie Yu |
Re: Review Request 66409: Used `csi::v0::VolumeCapability` in disk profile adaptors. |
Thu, 12 Apr, 16:50 |
| Jie Yu |
Re: Review Request 66410: Adapted storage local resource provider to use CSI v0.2. |
Thu, 12 Apr, 17:32 |
| Jie Yu |
Re: Review Request 66408: Updated CSI helpers for v0.2. |
Thu, 12 Apr, 17:47 |
| Jie Yu |
Re: Review Request 66411: Made the test CSI plugin compatible to CSI v0.2. |
Thu, 12 Apr, 17:56 |
| Jie Yu |
Re: Review Request 66418: Handled failed publish and unpublish CSI calls properly. |
Thu, 12 Apr, 22:54 |
| Jie Yu |
Re: Review Request 66574: Updated filesystem layout for staging and mounting CSI volumes. |
Thu, 12 Apr, 23:21 |
| Jie Yu |
Re: Review Request 66575: Supported `STAGE_UNSTAGE_VOLUME` CSI node capability in SLRP. |
Thu, 12 Apr, 23:41 |
| Jie Yu |
Re: Review Request 66576: Added `STAGE_UNSTAGE_VOLUME` capability to the test CSI plugin. |
Thu, 12 Apr, 23:48 |
| Jie Yu |
Re: Review Request 65974: Added comments and made some renaming in SLRP. |
Thu, 12 Apr, 23:50 |
| Jie Yu |
Re: Review Request 64921: Fixed a typo and formatting in docs. |
Fri, 13 Apr, 22:00 |
| Jie Yu |
Re: Review Request 64922: Added VOTING replica catch-up section to replicated log docs. |
Fri, 13 Apr, 22:01 |
| Jie Yu |
Re: Review Request 64923: Added replicated log reader catch-up section to the upgrades doc. |
Fri, 13 Apr, 22:02 |
| Jie Yu |
Re: Review Request 65594: Checkpointed profiles in storage local resource provider. |
Fri, 13 Apr, 22:45 |
| John Kordich via Review Board |
Re: Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess. |
Wed, 04 Apr, 21:15 |
| John Kordich via Review Board |
Re: Review Request 66422: Windows: Included used `jobobject.hpp` stout header in Mesos. |
Wed, 04 Apr, 21:16 |
| John Kordich via Review Board |
Re: Review Request 66426: Windows: More constness in stout. |
Wed, 04 Apr, 21:17 |
| John Kordich via Review Board |
Re: Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`. |
Wed, 04 Apr, 21:19 |
| John Kordich via Review Board |
Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly. |
Wed, 04 Apr, 21:20 |
| John Kordich via Review Board |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Wed, 04 Apr, 21:21 |
| John Kordich via Review Board |
Re: Review Request 66441: Fixed mismatched types in `process.cpp`. |
Wed, 04 Apr, 21:21 |
| John Kordich via Review Board |
Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`. |
Wed, 04 Apr, 21:22 |
| John Kordich via Review Board |
Re: Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`. |
Wed, 04 Apr, 21:22 |
| John Kordich via Review Board |
Re: Review Request 66444: Windows: Made `signals.hpp` compile. |
Wed, 04 Apr, 21:23 |
| John Kordich via Review Board |
Re: Review Request 66445: Windows: Cleaned up included CRT headers. |
Wed, 04 Apr, 21:23 |
| John Kordich via Review Board |
Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. |
Wed, 04 Apr, 22:12 |
| John Kordich via Review Board |
Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. |
Wed, 04 Apr, 22:12 |
| John Kordich via Review Board |
Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files. |
Wed, 04 Apr, 22:13 |
| John Kordich via Review Board |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Wed, 04 Apr, 22:16 |
| John Kordich via Review Board |
Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef. |
Wed, 04 Apr, 22:17 |
| John Kordich via Review Board |
Re: Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files. |
Wed, 04 Apr, 22:17 |
| John Kordich via Review Board |
Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. |
Wed, 04 Apr, 22:21 |
| John Kordich via Review Board |
Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace. |
Wed, 04 Apr, 22:22 |
| John Kordich via Review Board |
Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`. |
Wed, 04 Apr, 22:24 |
| John Kordich via Review Board |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 22:28 |
| John Kordich via Review Board |
Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. |
Wed, 04 Apr, 22:31 |
| John Kordich via Review Board |
Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 22:33 |
| John Kordich via Review Board |
Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`. |
Wed, 04 Apr, 22:35 |
| John Kordich via Review Board |
Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`. |
Wed, 04 Apr, 22:37 |
| John Kordich via Review Board |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Wed, 04 Apr, 22:46 |
| John Kordich via Review Board |
Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 22:53 |
| John Kordich via Review Board |
Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`. |
Wed, 04 Apr, 22:54 |
| John Kordich via Review Board |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Thu, 05 Apr, 17:44 |
| John Kordich via Review Board |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Fri, 27 Apr, 18:48 |
| John Kordich via Review Board |
Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`. |
Fri, 27 Apr, 18:49 |