| Benjamin Bannier |
Re: Review Request 66308: Delayed construction of the agent's resource provider manager. |
Fri, 20 Apr, 10:23 |
| Benjamin Bannier |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Fri, 20 Apr, 10:23 |
| Benjamin Bannier |
Re: Review Request 61096: Building gRPC with CMake. |
Fri, 20 Apr, 10:40 |
| Benjamin Bannier |
Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests. |
Fri, 20 Apr, 11:26 |
| Benjamin Bannier |
Re: Review Request 65974: Added comments and made some renaming in SLRP. |
Fri, 20 Apr, 11:30 |
| Benjamin Bannier |
Re: Review Request 65594: Checkpointed profiles in storage local resource provider. |
Fri, 20 Apr, 12:57 |
| Benjamin Bannier |
Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP. |
Fri, 20 Apr, 13:27 |
| Benjamin Bannier |
Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP. |
Fri, 20 Apr, 13:33 |
| Benjamin Bannier |
Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`. |
Fri, 20 Apr, 13:39 |
| Benjamin Bannier |
Re: Review Request 66310: Passed on registrar when constructing resource provider manager. |
Mon, 23 Apr, 11:18 |
| Benjamin Bannier |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Mon, 23 Apr, 11:19 |
| Benjamin Bannier |
Re: Review Request 66545: Added admitted resource providers to the manager's registry. |
Mon, 23 Apr, 11:19 |
| Benjamin Bannier |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Mon, 23 Apr, 11:19 |
| Benjamin Bannier |
Re: Review Request 66544: Remembered recovered and subscribed providers in ephemeral state. |
Mon, 23 Apr, 11:19 |
| Benjamin Bannier |
Re: Review Request 66310: Passed on registrar when constructing resource provider manager. |
Mon, 23 Apr, 11:20 |
| Benjamin Bannier |
Re: Review Request 66759: Fixed a regression in isolator ordering. |
Mon, 23 Apr, 11:30 |
| Benjamin Bannier |
Review Request 66762: Removed `developers` from Java binding mesos.pom file. |
Mon, 23 Apr, 13:27 |
| Benjamin Bannier |
Re: Review Request 66608: Improved support for move-only types in `hashmap`. |
Mon, 23 Apr, 21:52 |
| Benjamin Bannier |
Re: Review Request 66779: Inserted explicit moves in libprocess. |
Tue, 24 Apr, 18:58 |
| Benjamin Bannier |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Tue, 24 Apr, 19:28 |
| Benjamin Bannier |
Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs. |
Tue, 24 Apr, 19:28 |
| Benjamin Bannier |
Review Request 66780: Removed redundant master flags in resource provider tests. |
Tue, 24 Apr, 19:28 |
| Benjamin Bannier |
Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs. |
Tue, 24 Apr, 19:29 |
| Benjamin Bannier |
Re: Review Request 66545: Added admitted resource providers to the manager's registry. |
Tue, 24 Apr, 19:29 |
| Benjamin Bannier |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Tue, 24 Apr, 19:29 |
| Benjamin Bannier |
Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs. |
Wed, 25 Apr, 10:55 |
| Benjamin Bannier |
Re: Review Request 66545: Added admitted resource providers to the manager's registry. |
Wed, 25 Apr, 10:56 |
| Benjamin Bannier |
Re: Review Request 66526: Renamed resource provider `AgentRegistrar` to `GenericRegistrar`. |
Wed, 25 Apr, 10:56 |
| Benjamin Bannier |
Re: Review Request 66311: Set up recovery code paths of resource provider manager. |
Thu, 26 Apr, 12:39 |
| Benjamin Bannier |
Re: Review Request 66310: Passed on registrar when constructing resource provider manager. |
Thu, 26 Apr, 12:39 |
| Benjamin Bannier |
Re: Review Request 66840: Added `libacl` into Dockerfiles for the `mesos/mesos-build` image. |
Fri, 27 Apr, 07:12 |
| Benjamin Bannier |
Re: Review Request 66811: Added `libacl` as a dependency of stout. |
Fri, 27 Apr, 10:04 |
| Benjamin Bannier |
Review Request 66849: Added missing test expectation. |
Fri, 27 Apr, 10:15 |
| Benjamin Bannier |
Re: Review Request 66840: Added `libacl` into a few Dockerfiles. |
Fri, 27 Apr, 13:35 |
| Benjamin Bannier |
Re: Review Request 66811: Added `libacl` as a dependency of stout. |
Sun, 29 Apr, 12:17 |
| Benjamin Bannier |
Review Request 66868: Used `operator->` instead of `get`. |
Mon, 30 Apr, 09:14 |
| Benjamin Mahler |
Re: Review Request 66342: Added difference operator overload for hashset. |
Fri, 06 Apr, 03:25 |
| Benjamin Mahler |
Re: Review Request 66343: Added test for difference operator of hashset. |
Fri, 06 Apr, 03:26 |
| Benjamin Mahler |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 20:45 |
| Benjamin Mahler |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 20:50 |
| Benjamin Mahler |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Tue, 10 Apr, 21:47 |
| Benjamin Mahler |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Tue, 10 Apr, 22:00 |
| Benjamin Mahler |
Re: Review Request 66044: Refactored resources chopping logic in allocator. |
Wed, 11 Apr, 00:28 |
| Benjamin Mahler |
Re: Review Request 65334: Added quota limit to the master API protos. |
Wed, 11 Apr, 01:25 |
| Benjamin Mahler |
Re: Review Request 65334: Added quota limit to the master API protos. |
Wed, 11 Apr, 01:32 |
| Benjamin Mahler |
Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). |
Wed, 11 Apr, 02:01 |
| Benjamin Mahler |
Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). |
Wed, 11 Apr, 02:06 |
| Benjamin Mahler |
Re: Review Request 66553: Restructured Web UI. |
Wed, 11 Apr, 22:36 |
| Benjamin Mahler |
Re: Review Request 66554: Updated Web UI controllers to have one file per controller. |
Wed, 11 Apr, 22:42 |
| Benjamin Mahler |
Re: Review Request 63295: Update glog-0.3.3.patch to build on ARM. |
Thu, 12 Apr, 01:33 |
| Benjamin Mahler |
Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. |
Thu, 12 Apr, 02:23 |
| Benjamin Mahler |
Re: Review Request 66692: Fixed an documentation error in `monitoring.md`. |
Mon, 23 Apr, 21:38 |
| Benjamin Mahler |
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. |
Tue, 24 Apr, 00:43 |
| Benjamin Mahler |
Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer. |
Tue, 24 Apr, 17:31 |
| Benjamin Mahler |
Review Request 66828: Introduced a push-based gauge metric. |
Thu, 26 Apr, 21:54 |
| Benjamin Mahler |
Review Request 66830: Added a test for PushGauge. |
Thu, 26 Apr, 21:54 |
| Benjamin Mahler |
Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge. |
Thu, 26 Apr, 21:54 |
| Benjamin Mahler |
Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming. |
Thu, 26 Apr, 21:54 |
| Benjamin Mahler |
Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path. |
Sun, 29 Apr, 01:40 |
| Benjamin Mahler |
Re: Review Request 66863: Reduced likelihood of a stack overflow in libprocess socket send path. |
Mon, 30 Apr, 23:47 |
| Benno Evers |
Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith(). |
Tue, 03 Apr, 16:27 |
| Benno Evers |
Re: Review Request 63366: Add jemalloc release tarball and build rules. |
Tue, 03 Apr, 16:28 |
| Benno Evers |
Re: Review Request 63368: Added MemoryProfiler class to Libprocess. |
Tue, 03 Apr, 16:29 |
| Benno Evers |
Re: Review Request 65462: Used the new 'route()' overload from libprocess. |
Thu, 05 Apr, 10:28 |
| Benno Evers |
Re: Review Request 63366: Add jemalloc release tarball and build rules. |
Tue, 10 Apr, 14:38 |
| Benno Evers |
Re: Review Request 63368: Added MemoryProfiler class to Libprocess. |
Tue, 10 Apr, 14:39 |
| Benno Evers |
Re: Review Request 63368: Added MemoryProfiler class to Libprocess. |
Tue, 10 Apr, 14:48 |
| Benno Evers |
Re: Review Request 65462: Used the new 'route()' overload from libprocess. |
Fri, 13 Apr, 11:14 |
| Benno Evers |
Re: Review Request 63366: Added jemalloc release tarball and build rules. |
Fri, 13 Apr, 12:03 |
| Benno Evers |
Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries. |
Fri, 13 Apr, 18:48 |
| Benno Evers |
Re: Review Request 63372: Added documentation for memory profiling. |
Fri, 13 Apr, 18:49 |
| Benno Evers |
Re: Review Request 63368: Added MemoryProfiler class to Libprocess. |
Mon, 16 Apr, 14:55 |
| Benno Evers |
Review Request 66643: WIP: Attribute filters. |
Mon, 16 Apr, 21:28 |
| Benno Evers |
Review Request 66666: Added MemoryProfiler to CHANGELOG. |
Tue, 17 Apr, 13:33 |
| Benno Evers |
Re: Review Request 66577: Enabled CSI proto compilation by default. |
Tue, 17 Apr, 18:19 |
| Benno Evers |
Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries. |
Wed, 18 Apr, 04:15 |
| Benno Evers |
Re: Review Request 63368: Added MemoryProfiler class to Libprocess. |
Wed, 18 Apr, 04:15 |
| Benno Evers |
Re: Review Request 63366: Added jemalloc release tarball and build rules. |
Wed, 18 Apr, 04:15 |
| Benno Evers |
Re: Review Request 63366: Added jemalloc release tarball and build rules. |
Wed, 18 Apr, 04:15 |
| Benno Evers |
Review Request 66699: Added include to stouts os.hpp header. |
Wed, 18 Apr, 20:55 |
| Benno Evers |
Review Request 66700: Changed call from os::shell() to os::system(). |
Wed, 18 Apr, 20:56 |
| Benno Evers |
Re: Review Request 66711: Made 3rdparty jemalloc only build when enabled. |
Thu, 19 Apr, 12:43 |
| Benno Evers |
Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries. |
Mon, 23 Apr, 21:08 |
| Benno Evers |
Re: Review Request 66666: Added MemoryProfiler to CHANGELOG. |
Mon, 23 Apr, 21:09 |
| Benno Evers |
Review Request 66776: Changed failure check for a call to os::system(). |
Tue, 24 Apr, 14:40 |
| Benno Evers |
Re: Review Request 63372: Added documentation for memory profiling. |
Tue, 24 Apr, 14:40 |
| Benno Evers |
Re: Review Request 63372: Added documentation for memory profiling. |
Tue, 24 Apr, 14:42 |
| Benno Evers |
Re: Review Request 66666: Added MemoryProfiler to CHANGELOG. |
Tue, 24 Apr, 16:41 |
| Benno Evers |
Re: Review Request 63372: Added documentation for memory profiling. |
Wed, 25 Apr, 14:07 |
| Benno Evers |
Re: Review Request 63372: Added documentation for memory profiling. |
Wed, 25 Apr, 14:09 |
| Benno Evers |
Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'. |
Wed, 25 Apr, 16:46 |
| Benno Evers |
Review Request 66405: Doc improvements (wip). |
Thu, 26 Apr, 09:59 |
| Benno Evers |
Re: Review Request 63371: Added unit test for new MemoryProfiler class. |
Thu, 26 Apr, 09:59 |
| Benno Evers |
Review Request 66815: Removed an unconditional .get() in DefaultExecutor. |
Thu, 26 Apr, 15:24 |
| Chun-Hung Hsiao |
Review Request 66398: Bumped the CSI spec bundle to 0.2.0. |
Tue, 03 Apr, 18:45 |
| Chun-Hung Hsiao |
Review Request 66407: Updated CSI client to support v0.2. |
Tue, 03 Apr, 19:12 |
| Chun-Hung Hsiao |
Review Request 66408: Updated CSI helpers for v0.2. |
Tue, 03 Apr, 19:15 |
| Chun-Hung Hsiao |
Review Request 66409: Used `csi::v0::VolumeCapability` in disk profile adaptors. |
Tue, 03 Apr, 19:18 |
| Chun-Hung Hsiao |
Review Request 66410: Adapted storage local resource provider to use CSI v0.2. |
Tue, 03 Apr, 19:20 |
| Chun-Hung Hsiao |
Review Request 66411: Made the test CSI plugin compatible to CSI v0.2. |
Tue, 03 Apr, 19:22 |