Andrew Schwartzmeyer |
Re: Review Request 66385: Link execinfo in Glog build on FreeBSD. |
Tue, 03 Apr, 16:40 |
Andrew Schwartzmeyer |
Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD. |
Tue, 03 Apr, 16:41 |
Andrew Schwartzmeyer |
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD. |
Tue, 03 Apr, 16:42 |
Andrew Schwartzmeyer |
Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. |
Wed, 04 Apr, 05:46 |
Andrew Schwartzmeyer |
Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess. |
Wed, 04 Apr, 05:47 |
Andrew Schwartzmeyer |
Review Request 66422: Windows: Included used `jobobject.hpp` stout header in Mesos. |
Wed, 04 Apr, 05:47 |
Andrew Schwartzmeyer |
Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files. |
Wed, 04 Apr, 05:47 |
Andrew Schwartzmeyer |
Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Wed, 04 Apr, 05:47 |
Andrew Schwartzmeyer |
Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef. |
Wed, 04 Apr, 05:47 |
Andrew Schwartzmeyer |
Review Request 66426: Windows: More constness in stout. |
Wed, 04 Apr, 05:48 |
Andrew Schwartzmeyer |
Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files. |
Wed, 04 Apr, 05:48 |
Andrew Schwartzmeyer |
Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. |
Wed, 04 Apr, 05:49 |
Andrew Schwartzmeyer |
Review Request 66429: Windows: Deleted dead code from `process::internal` namespace. |
Wed, 04 Apr, 05:49 |
Andrew Schwartzmeyer |
Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`. |
Wed, 04 Apr, 05:50 |
Andrew Schwartzmeyer |
Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 05:50 |
Andrew Schwartzmeyer |
Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. |
Wed, 04 Apr, 05:50 |
Andrew Schwartzmeyer |
Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 05:51 |
Andrew Schwartzmeyer |
Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`. |
Wed, 04 Apr, 05:51 |
Andrew Schwartzmeyer |
Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`. |
Wed, 04 Apr, 05:52 |
Andrew Schwartzmeyer |
Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`. |
Wed, 04 Apr, 05:54 |
Andrew Schwartzmeyer |
Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Wed, 04 Apr, 05:55 |
Andrew Schwartzmeyer |
Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly. |
Wed, 04 Apr, 05:56 |
Andrew Schwartzmeyer |
Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 05:56 |
Andrew Schwartzmeyer |
Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Wed, 04 Apr, 05:57 |
Andrew Schwartzmeyer |
Review Request 66441: Fixed mismatched types in `process.cpp`. |
Wed, 04 Apr, 05:57 |
Andrew Schwartzmeyer |
Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`. |
Wed, 04 Apr, 05:57 |
Andrew Schwartzmeyer |
Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`. |
Wed, 04 Apr, 05:58 |
Andrew Schwartzmeyer |
Review Request 66444: Windows: Made `signals.hpp` compile. |
Wed, 04 Apr, 05:58 |
Andrew Schwartzmeyer |
Review Request 66445: Windows: Cleaned up included CRT headers. |
Wed, 04 Apr, 05:58 |
Andrew Schwartzmeyer |
Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 06:00 |
Andrew Schwartzmeyer |
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it. |
Wed, 04 Apr, 17:04 |
Andrew Schwartzmeyer |
Re: Review Request 66444: Windows: Made `signals.hpp` compile. |
Wed, 04 Apr, 17:22 |
Andrew Schwartzmeyer |
Re: Review Request 66441: Fixed mismatched types in `process.cpp`. |
Wed, 04 Apr, 17:29 |
Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 17:31 |
Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 19:13 |
Andrew Schwartzmeyer |
Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`. |
Wed, 04 Apr, 19:15 |
Andrew Schwartzmeyer |
Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace. |
Wed, 04 Apr, 19:17 |
Andrew Schwartzmeyer |
Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`. |
Wed, 04 Apr, 19:18 |
Andrew Schwartzmeyer |
Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly. |
Wed, 04 Apr, 19:18 |
Andrew Schwartzmeyer |
Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly. |
Wed, 04 Apr, 19:19 |
Andrew Schwartzmeyer |
Re: Review Request 66445: Windows: Cleaned up included CRT headers. |
Wed, 04 Apr, 19:26 |
Andrew Schwartzmeyer |
Re: Review Request 66441: Fixed mismatched types in `process.cpp`. |
Wed, 04 Apr, 21:43 |
Andrew Schwartzmeyer |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Wed, 04 Apr, 21:49 |
Andrew Schwartzmeyer |
Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`. |
Wed, 04 Apr, 22:24 |
Andrew Schwartzmeyer |
Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. |
Wed, 04 Apr, 22:25 |
Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Wed, 04 Apr, 22:35 |
Andrew Schwartzmeyer |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Thu, 05 Apr, 01:58 |
Andrew Schwartzmeyer |
Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`. |
Thu, 05 Apr, 02:06 |
Andrew Schwartzmeyer |
Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD. |
Thu, 05 Apr, 20:54 |
Andrew Schwartzmeyer |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Thu, 05 Apr, 23:19 |
Andrew Schwartzmeyer |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Thu, 05 Apr, 23:21 |
Andrew Schwartzmeyer |
Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`. |
Thu, 05 Apr, 23:50 |
Andrew Schwartzmeyer |
Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`. |
Fri, 06 Apr, 00:03 |
Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Fri, 06 Apr, 17:57 |
Andrew Schwartzmeyer |
Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. |
Fri, 06 Apr, 18:03 |
Andrew Schwartzmeyer |
Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`. |
Fri, 06 Apr, 22:52 |
Andrew Schwartzmeyer |
Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`. |
Fri, 06 Apr, 22:53 |
Andrew Schwartzmeyer |
Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `FileEndOfFileInfo`. |
Fri, 06 Apr, 23:09 |
Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Fri, 06 Apr, 23:11 |
Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Fri, 06 Apr, 23:13 |
Andrew Schwartzmeyer |
Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`. |
Fri, 06 Apr, 23:14 |
Andrew Schwartzmeyer |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Fri, 06 Apr, 23:15 |
Andrew Schwartzmeyer |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Fri, 06 Apr, 23:15 |
Andrew Schwartzmeyer |
Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly. |
Fri, 06 Apr, 23:16 |
Andrew Schwartzmeyer |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Fri, 06 Apr, 23:17 |
Andrew Schwartzmeyer |
Re: Review Request 66445: Windows: Cleaned up included CRT headers. |
Fri, 06 Apr, 23:18 |
Andrew Schwartzmeyer |
Re: Review Request 66038: Add usageWithInode to check both disk and inode usage. |
Mon, 09 Apr, 20:40 |
Andrew Schwartzmeyer |
Re: Review Request 66038: Add usageWithInode to check both disk and inode usage. |
Mon, 09 Apr, 21:01 |
Andrew Schwartzmeyer |
Re: Review Request 66481: Converted `pid` in command executor to `Option<pid_t>`. |
Mon, 09 Apr, 21:16 |
Andrew Schwartzmeyer |
Re: Review Request 66493: Made FreeBSD default to non-GNU ld. |
Mon, 09 Apr, 21:22 |
Andrew Schwartzmeyer |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Mon, 09 Apr, 22:07 |
Andrew Schwartzmeyer |
Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`. |
Mon, 09 Apr, 22:09 |
Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Mon, 09 Apr, 22:40 |
Andrew Schwartzmeyer |
Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`. |
Mon, 09 Apr, 22:53 |
Andrew Schwartzmeyer |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Tue, 10 Apr, 19:04 |
Andrew Schwartzmeyer |
Re: Review Request 66493: Made FreeBSD default to non-GNU ld. |
Wed, 11 Apr, 23:38 |
Andrew Schwartzmeyer |
Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction. |
Thu, 12 Apr, 02:06 |
Andrew Schwartzmeyer |
Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`. |
Thu, 12 Apr, 02:06 |
Andrew Schwartzmeyer |
Re: Review Request 66493: Made FreeBSD default to non-GNU ld. |
Thu, 12 Apr, 16:27 |
Andrew Schwartzmeyer |
Re: Review Request 61096: Building gRPC with CMake. |
Thu, 12 Apr, 16:41 |
Andrew Schwartzmeyer |
Re: Review Request 66577: Enabled CSI proto compilation by default. |
Thu, 12 Apr, 16:44 |
Andrew Schwartzmeyer |
Re: Review Request 61118: Libprocess: Building gRPC support with CMake. |
Thu, 12 Apr, 16:55 |
Andrew Schwartzmeyer |
Re: Review Request 66163: Built storage local resource provider with CMake. |
Thu, 12 Apr, 17:06 |
Andrew Schwartzmeyer |
Re: Review Request 66163: Built storage local resource provider with CMake. |
Thu, 12 Apr, 17:10 |
Andrew Schwartzmeyer |
Re: Review Request 66038: Add inodeUsage to provide inode usage. |
Sat, 14 Apr, 22:12 |
Andrew Schwartzmeyer |
Re: Review Request 66577: Enabled CSI proto compilation by default. |
Mon, 16 Apr, 16:46 |
Andrew Schwartzmeyer |
Re: Review Request 66616: Marked volume/block creation and destroy operations as experimental. |
Mon, 16 Apr, 16:47 |
Andrew Schwartzmeyer |
Review Request 66641: Added `FsTest.Open` to cover `os::open()`. |
Mon, 16 Apr, 20:24 |
Andrew Schwartzmeyer |
Re: Review Request 61096: Building gRPC with CMake. |
Wed, 18 Apr, 18:54 |
Andrew Schwartzmeyer |
Re: Review Request 61096: Building gRPC with CMake. |
Wed, 18 Apr, 18:57 |
Andrew Schwartzmeyer |
Re: Review Request 61118: Building gRPC support in libprocess with CMake. |
Wed, 18 Apr, 18:59 |
Andrew Schwartzmeyer |
Re: Review Request 61118: Building gRPC support in libprocess with CMake. |
Wed, 18 Apr, 19:02 |
Andrew Schwartzmeyer |
Re: Review Request 66163: Built storage local resource provider with CMake. |
Wed, 18 Apr, 19:10 |
Andrew Schwartzmeyer |
Re: Review Request 66163: Built storage local resource provider with CMake. |
Wed, 18 Apr, 19:22 |
Andrew Schwartzmeyer |
Re: Review Request 66699: Added include to stouts os.hpp header. |
Wed, 18 Apr, 21:59 |
Andrew Schwartzmeyer |
Re: Review Request 66699: Added include to stouts os.hpp header. |
Wed, 18 Apr, 23:49 |
Andrew Schwartzmeyer |
Re: Review Request 66700: Changed call from os::shell() to os::system(). |
Wed, 18 Apr, 23:53 |
Andrew Schwartzmeyer |
Review Request 66709: Windows: Fixed Ninja in Release configuration. |
Thu, 19 Apr, 01:17 |
Andrew Schwartzmeyer |
Review Request 66711: Made 3rdparty jemalloc only build when enabled. |
Thu, 19 Apr, 02:12 |
Andrew Schwartzmeyer |
Re: Review Request 66711: Made 3rdparty jemalloc only build when enabled. |
Thu, 19 Apr, 04:42 |