mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 66259: Added `max_completion_time` support to command executor.
Date Mon, 30 Apr 2018 23:33:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66259/#review202150
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/executor.cpp
Lines 1052 (patched)
<https://reviews.apache.org/r/66259/#comment283782>

    ```
    "its maximum completion time of " << duration;
    ```



src/launcher/executor.cpp
Lines 1187 (patched)
<https://reviews.apache.org/r/66259/#comment283783>

    This comment looks stale?


- James Peach


On April 23, 2018, 10:18 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66259/
> -----------------------------------------------------------
> 
> (Updated April 23, 2018, 10:18 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If `TaskInfo.max_completion_time` is set, command executor will kill
> the task with `SIGKILL` immediately. Note that no KillPolicy will be
> observed. Framework should only received a `TASK_FAILED` state with
> `REASON_MAX_COMPLETION_TIME_REACHED` reason.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 8d0869cfcdfc693301d0e185a036e97204bad17f 
> 
> 
> Diff: https://reviews.apache.org/r/66259/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message