mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 66284: Tested `max_completion_time` support in docker executor.
Date Mon, 30 Apr 2018 23:27:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66284/#review202155
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/docker_containerizer_tests.cpp
Lines 630 (patched)
<https://reviews.apache.org/r/66284/#comment283792>

    Rebase onto master and use local helper:
    ```
    // TODO(tnachen): Use local image to test if possible.
    task.mutable_container()->CopyFrom(createDockerInfo("alpine"));
    ```


- James Peach


On April 27, 2018, 4:09 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66284/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 4:09 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested `max_completion_time` support in docker executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 5e3dfdb537f52a85a82c6e8195e70a389b76aadf

> 
> 
> Diff: https://reviews.apache.org/r/66284/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message