mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 66291: Added support to `max_completion_time` in default executor.
Date Mon, 30 Apr 2018 23:27:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66291/#review202156
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp
Lines 1291 (patched)
<https://reviews.apache.org/r/66291/#comment283796>

    Use a log error message:
    ```
       LOG(INFO) << "Killing task " << taskId
                 << " which exceeded its maximum completion time of " << duration;
    ```


- James Peach


On April 23, 2018, 11:56 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66291/
> -----------------------------------------------------------
> 
> (Updated April 23, 2018, 11:56 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a task group has multiple tasks:
> - each task can have its own `max_completion_time`, or not have one;
> - if a task succeeds before its `max_completion_time`, all other tasks
> will keep running;
> - if a task fails, all other tasks in the same group will fail (as
> before);
> - if a task does not succeed before its `max_completion_time`, it will
> fail with `TASK_FAILED` and reason `REASON_MAX_COMPLETION_TIME_REACHED`,
> while other tasks will be killed without above reason.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 
> 
> 
> Diff: https://reviews.apache.org/r/66291/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message