mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 66293: Tested default executor support of `max_completion_time`.
Date Mon, 30 Apr 2018 23:21:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66293/#review202160
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/default_executor_tests.cpp
Lines 1764 (patched)
<https://reviews.apache.org/r/66293/#comment283809>

    I think it would be a little safer to make this task just run "exit 0" since it might
take a long time to start up on a slow CI host.


- James Peach


On April 8, 2018, 12:54 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66293/
> -----------------------------------------------------------
> 
> (Updated April 8, 2018, 12:54 a.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Tested default executor support of `max_completion_time`.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp bf849c4b636e81ec267112bff9621579998941f5 
> 
> 
> Diff: https://reviews.apache.org/r/66293/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message