mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`.
Date Mon, 30 Apr 2018 22:35:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53105/
-----------------------------------------------------------

(Updated April 30, 2018, 3:35 p.m.)


Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu.


Changes
-------

Rebase to revive the patch.


Bugs: MESOS-6451
    https://issues.apache.org/jira/browse/MESOS-6451


Repository: mesos


Description
-------

Added an hourly timer for `slave/docker_containerizer/pull`.


Diffs (updated)
-----

  src/slave/containerizer/docker.hpp 6bdf4c7f60384473927de437a061fafe94170557 
  src/slave/containerizer/docker.cpp a4c9c10e91e75f406329cbb2086f39b549cbeed0 


Diff: https://reviews.apache.org/r/53105/diff/5/

Changes: https://reviews.apache.org/r/53105/diff/4-5/


Testing
-------

Ran `mesos-execute` with a docker image and docker containerizer, observed the following metrics:
```
curl -s localhost:5051/metrics/snapshot | jq . | grep pull
  "containerizer/docker/pull_ms/p999": 26209.36173824,
  "containerizer/docker/pull_ms/p90": 21036.405248,
  "containerizer/docker/pull_ms/p9999": 26256.388615424,
  "containerizer/docker/pull_ms/p50": 135.570944,
  "containerizer/docker/pull_ms/max": 26261.613824,
  "containerizer/docker/pull_ms/p95": 23649.009536,
  "containerizer/docker/pull_ms/min": 103.215872,
  "containerizer/docker/pull_ms/p99": 25739.0929664,
  "containerizer/docker/pull_ms": 26261.613824,
  "containerizer/docker/pull_ms/count": 3
```


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message