mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 53267: Added a gauge to track active subscribers.
Date Mon, 30 Apr 2018 20:53:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/
-----------------------------------------------------------

(Updated April 30, 2018, 1:53 p.m.)


Review request for mesos, Anand Mazumdar, Jason Lai, and James Peach.


Changes
-------

Rebase and move.


Bugs: MESOS-6499
    https://issues.apache.org/jira/browse/MESOS-6499


Repository: mesos


Description
-------

Added a gauge to track active subscribers.


Diffs (updated)
-----

  src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
  src/master/metrics.hpp 5414c4790f4606f910b0de81cbb08d398a0f3745 
  src/master/metrics.cpp 4cc96a1be532d6c7333a9fcdf8739d7640180777 


Diff: https://reviews.apache.org/r/53267/diff/3/

Changes: https://reviews.apache.org/r/53267/diff/2-3/


Testing
-------

Ran this on master with a client keeps subscribing and disconnecting. Observes that gauge
gets updated and new log line is printed.


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message