mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.
Date Mon, 30 Apr 2018 18:25:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/#review202128
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/windows/os.hpp
Lines 338 (patched)
<https://reviews.apache.org/r/66578/#comment283767>

    The POSIX implementation ignores `EINTR` so I think the equivalent on Windows would be
a non-alertable sleep.



3rdparty/stout/tests/os_tests.cpp
Lines 204 (patched)
<https://reviews.apache.org/r/66578/#comment283766>

    I guess you can try if you can set a valid socket to non blocking mode.


- Akash Gupta


On April 27, 2018, 4:20 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66578/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 4:20 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael
Park.
> 
> 
> Bugs: MESOS-3441
>     https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed `os::sleep()` to return an invalid parameter error if given a
> negative value.
> 
> Fixed tests around the `cloexec` and `nonblock` stubs.
> 
> Extended the `bootid` test to use `std::chrono` to assert the boot
> id (which is the system boot time) is a reasonable value.
> 
> Permanently disabled `OsTest.Libraries` because there is no
> equivalent.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/bootid.hpp d24e115b97ebcabfa808a9437fb41512f25a5271

>   3rdparty/stout/include/stout/windows/os.hpp 900baf9be4e3089cb43e444b14b155a80bcd1591

>   3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 
> 
> 
> Diff: https://reviews.apache.org/r/66578/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message