mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66868: Used `operator->` instead of `get`.
Date Mon, 30 Apr 2018 11:47:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66868/#review202116
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66868]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 30, 2018, 9:14 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66868/
> -----------------------------------------------------------
> 
> (Updated April 30, 2018, 9:14 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used `operator->` instead of `get`.
> 
> 
> Diffs
> -----
> 
>   src/tests/disk_profile_adaptor_tests.cpp ce11d47d2cc95abcdc80f4d40ea4d005cabbc586 
> 
> 
> Diff: https://reviews.apache.org/r/66868/diff/1/
> 
> 
> Testing
> -------
> 
> With grpc enabled:
> 
> * `make check`
> * ran mesos-tidy
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message