mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66811: Added `libacl` as a dependency of stout.
Date Sun, 29 Apr 2018 12:17:43 GMT


> On April 27, 2018, 12:04 p.m., Benjamin Bannier wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 288 (patched)
> > <https://reviews.apache.org/r/66811/diff/2/?file=2014091#file2014091line288>
> >
> >     This file should not be committed together with the changes to stout (project
split).
> 
> Andrew Schwartzmeyer wrote:
>     Why didn't the hooks catch this?

They did for me, maybe you and Qian need to check how you apply patches and whether your hooks
are correctly set up and invoked.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66811/#review202058
-----------------------------------------------------------


On April 27, 2018, 3:35 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66811/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 3:35 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8809
>     https://issues.apache.org/jira/browse/MESOS-8809
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `libacl` as a dependency of stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb 
>   3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc 
>   3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
>   3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5 
> 
> 
> Diff: https://reviews.apache.org/r/66811/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message