mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
Date Fri, 27 Apr 2018 20:05:20 GMT


> On April 25, 2018, 4:59 p.m., Chun-Hung Hsiao wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 501-505 (patched)
> > <https://reviews.apache.org/r/66220/diff/7/?file=2011389#file2011389line501>
> >
> >     ```
> >     // Disk spaces will be merged if fixture parameter is `NONE`.
> >     Bytes totalBytes = GetParam() == NONE ? MegaBytes(4096) : MegaBytes(2048);
> >     ```
> >     
> >     TBH I'm not a fan of conditioning on the fixture parameters. If a new fixture
is created, this can be resolved by having only one disk in `getSlaveResources()` instead.
But given the fact that we also do similar conditional branches in other tests, I can live
with this.

I'll leave this as a TODO.


> On April 25, 2018, 4:59 p.m., Chun-Hung Hsiao wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 823 (patched)
> > <https://reviews.apache.org/r/66220/diff/7/?file=2011389#file2011389line823>
> >
> >     This is not required.

New test has offers so this will be necessary.


> On April 25, 2018, 4:59 p.m., Chun-Hung Hsiao wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 853-855 (patched)
> > <https://reviews.apache.org/r/66220/diff/7/?file=2011389#file2011389line853>
> >
> >     This is essentially testing the same property as the last `EXPECT_FALSE` so
we don't need it.

New test dropped this.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201969
-----------------------------------------------------------


On April 27, 2018, 1:04 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66220/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 1:04 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66220/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message