mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
Date Fri, 27 Apr 2018 20:04:56 GMT


> On April 25, 2018, 9:09 a.m., Greg Mann wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 585-586 (patched)
> > <https://reviews.apache.org/r/66220/diff/6/?file=2006752#file2006752line585>
> >
> >     IIUC, the `Clock::settle()` here is ensuring that this test actually verifies
that the agent's resources have been checkpointed?
> >     
> >     If so, I would recommend:
> >     1) Add a comment explaining the reason for the settle.
> >     2) Place the settle after the await. I think the two orderings are equivalent,
but I think it's more readable if the settle is after the await?
> 
> Chun-Hung Hsiao wrote:
>     The await can be removed. See my comments above.

This is necessary to make sure that master -> allocator communication for `allocator::updateAllocation()`
has happened.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201843
-----------------------------------------------------------


On April 27, 2018, 1:04 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66220/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 1:04 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66220/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message