mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.
Date Fri, 27 Apr 2018 18:32:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66844/#review202078
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66819, 66820, 66821, 66822, 66823, 66845, 66824, 66825, 66846, 66847, 66841,
66842, 66843, 66844]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 27, 2018, 6:03 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66844/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 6:03 p.m.)
> 
> 
> Review request for Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These metrics count the number of times that the allocator has
> filtered resources out of this framework's offer stream,
> with separate metrics for different types of filtering.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 955ae3e6a9e3c790fb260311ec4b4ef725a826d3

>   src/master/allocator/mesos/hierarchical.cpp 1000968be6a2935a4cac571414d7f06d7df7acf0

>   src/master/allocator/mesos/metrics.hpp d56a10b2d949180c081e7e285e8d60e6ea12ecfa 
>   src/master/allocator/mesos/metrics.cpp 4892dbce65e2f7c12ba5105e28855ba6b6bf800e 
> 
> 
> Diff: https://reviews.apache.org/r/66844/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message