mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66849: Added missing test expectation.
Date Fri, 27 Apr 2018 12:17:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66849/#review202060
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66849]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 27, 2018, 10:15 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66849/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 10:15 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> On master failover the scheduler will get disconnected. Add a test
> expectation for that. This silences a gmock warning.
> 
> 
> Diffs
> -----
> 
>   src/tests/operation_reconciliation_tests.cpp 76c169567de6e0ef99c984a673cd69ce7725d6b6

> 
> 
> Diff: https://reviews.apache.org/r/66849/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Before this patch the fixed tests emits a gmock warning about an unexpected function
call, with this patch the warning disappears.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message