mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge.
Date Thu, 26 Apr 2018 21:54:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66831/
-----------------------------------------------------------

Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James Peach, and Vinod
Kone.


Bugs: MESOS-8851
    https://issues.apache.org/jira/browse/MESOS-8851


Repository: mesos


Description
-------

Given `PushGauge`, it makes sense to explicitly distinguish the two
gauge types and document the the caveats of `PullGauge`.


Diffs
-----

  3rdparty/libprocess/include/Makefile.am cd2c3bc62df8de5b50ec2fa830b3e2634ba11e28 
  3rdparty/libprocess/include/process/metrics/gauge.hpp 474f8e80b0128ae8d742a022733019351710ef48

  3rdparty/libprocess/include/process/metrics/metric.hpp 21f162d5b7d9e56dc3289d65b6d86deb4c2fa721

  3rdparty/libprocess/include/process/metrics/pull_gauge.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/system.hpp 6bd815daa27c069e25461e73fcc7327c4645e9fc

  3rdparty/libprocess/src/tests/metrics_tests.cpp f2bd99bd289d728932b3206958902a99e436eaa7

  3rdparty/libprocess/src/tests/system_tests.cpp 17f288146c81b37a900b3df7d1797ba7bdfd00ca



Diff: https://reviews.apache.org/r/66831/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message