mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66531: Added new authorization for `ResizeVolume`.
Date Thu, 26 Apr 2018 18:04:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66531/#review201978
-----------------------------------------------------------


Fix it, then Ship it!





src/authorizer/local/authorizer.cpp
Lines 910-914 (patched)
<https://reviews.apache.org/r/66531/#comment283617>

    Let's move this below `case authorization::CREATE_VOLUME` for consistency.



src/master/master.hpp
Lines 895 (patched)
<https://reviews.apache.org/r/66531/#comment283673>

    s/`resource`/`volume`/. Or if you prefer keeping the parameter name as `resource`, please
update the above comment: `@param resource`, as well as the variable name in `Master::authorizeResizeVolume()`
in `master.cpp`.



src/master/master.cpp
Lines 4993 (patched)
<https://reviews.apache.org/r/66531/#comment283674>

    `to grow a volume`



src/master/master.cpp
Lines 5000 (patched)
<https://reviews.apache.org/r/66531/#comment283675>

    `to grow a volume`



src/master/master.cpp
Lines 5086 (patched)
<https://reviews.apache.org/r/66531/#comment283676>

    `to shrink a volume`



src/master/master.cpp
Lines 5093 (patched)
<https://reviews.apache.org/r/66531/#comment283677>

    `to shrink a volume`


- Chun-Hung Hsiao


On April 20, 2018, 11:16 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66531/
> -----------------------------------------------------------
> 
> (Updated April 20, 2018, 11:16 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
>     https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new authorization action is modelled after `CreateVolume`, and will
> be shared by both `GROW_VOLUME` and `SHRINK_VOLUME` operations and
> corresponding operator APIs.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 8ef33210644e7d2924b402a3158b1b38c1fdb464 
>   include/mesos/authorizer/authorizer.proto 1508c01130013d74ed2b2574a2428f38e3d2c064

>   src/authorizer/local/authorizer.cpp c098ba9ded1b29a2e079cf09ab80b61f6fa4af05 
>   src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
> 
> 
> Diff: https://reviews.apache.org/r/66531/diff/4/
> 
> 
> Testing
> -------
> 
> Manually created ACL and verified that untrusted principals will not allow to grow/shrink
volumes.
> Also created unit test in next patch.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message