mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.
Date Thu, 26 Apr 2018 17:51:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66815/#review202017
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66815]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 26, 2018, 3:24 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66815/
> -----------------------------------------------------------
> 
> (Updated April 26, 2018, 3:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8797
>     https://issues.apache.org/jira/browse/MESOS-8797
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This would fail in some cases where the optional
> message is `None`, e.g. when the container is in
> killing state.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp ea0d425bb60e970f209f411632e1d486c279259b 
> 
> 
> Diff: https://reviews.apache.org/r/66815/diff/1/
> 
> 
> Testing
> -------
> 
> `./src/mesos-tests --gtest_filter=MesosContainerizer/DefaultExecutorTest.TaskUsesExecutor/0
--gtest_repeat=500 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message