mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66776: Changed failure check for a call to os::system().
Date Wed, 25 Apr 2018 17:24:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66776/#review201949
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66776]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 24, 2018, 2:40 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66776/
> -----------------------------------------------------------
> 
> (Updated April 24, 2018, 2:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The previous check for `None()` was missing the case where the
> program exited with a non-zero exit status.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/memory_profiler.cpp 5d6e9dc9b6d26c0efd5f2383d5ad36a136861591

> 
> 
> Diff: https://reviews.apache.org/r/66776/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message