mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 63372: Added documentation for memory profiling.
Date Wed, 25 Apr 2018 14:09:15 GMT


> On April 24, 2018, 5:59 p.m., Alexander Rukletsov wrote:
> > Have you rendered using our website renderer?

Yes.


> On April 24, 2018, 5:59 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 54 (patched)
> > <https://reviews.apache.org/r/63372/diff/8/?file=2011064#file2011064line54>
> >
> >     I would like to explicitly tell people that this is the second part, with the
first being switching to jemalloc. Also, I would like to educate them, that the second (memory
profiling) requires the first, while the opposite is not true and people will likely reap
profit even without enabling memory profiling functionlaity.
> >     
> >     Can you please add this info somewhere to the doc?

I added a paragraph, but since this document is about memory profiling, I'm not sure how much
the non-memory-profiling related use cases of jemalloc are relevant here.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201844
-----------------------------------------------------------


On April 25, 2018, 2:07 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> -----------------------------------------------------------
> 
> (Updated April 25, 2018, 2:07 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message