mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.
Date Wed, 25 Apr 2018 06:18:36 GMT


> On April 17, 2018, 4:24 p.m., Greg Mann wrote:
> > src/tests/authorization_tests.cpp
> > Line 1979 (original), 1979 (patched)
> > <https://reviews.apache.org/r/66532/diff/2/?file=1996775#file1996775line1979>
> >
> >     Could you also add an end-to-end test of authorization for these operations?
> 
> Zhitao Li wrote:
>     Sure. Do you have an example or existing test to add this?
> 
> Greg Mann wrote:
>     There are some similar tests in both 'persistent_volume_tests.cpp' as well as 'master_authorization_tests.cpp'.
>     
>     Tests which do something very similar in the persistent volume tests are 'PersistentVolumeTest.BadACLDropCreateAndDestroy'
and 'PersistentVolumeTest.GoodACLCreateThenDestroy'. It would be good to verify both the successful
and failed authorization cases.

I've added some test cases. It seems that there will be some level of code duplication and
I'm not sure whether we want to follow the ones for `...CreateAndDrop`, or Chun's idea of
smaller tests verifying one thing at a time. We can definitely iterate on these. Marking this
comment as fixed.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review201362
-----------------------------------------------------------


On April 24, 2018, 11:16 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> -----------------------------------------------------------
> 
> (Updated April 24, 2018, 11:16 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
>     https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for authorization actions for `RESIZE_VOLUME`.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
>   src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message