mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
Date Wed, 25 Apr 2018 04:28:45 GMT


> On April 17, 2018, 10:52 p.m., Gaston Kleiman wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 474-475 (patched)
> > <https://reviews.apache.org/r/66220/diff/4/?file=1996762#file1996762line474>
> >
> >     I see that Benjamin recently added this line and the corresponding `AWAIT_READY`
to many tests.
> >     
> >     However I don't think it is necessary here; I'll check with Benjamin to see
if we can also remove it from other tests in which it is not necessary.
> 
> Zhitao Li wrote:
>     I'd like to keep this (see reasons above) because I've seen race condition on offer
otherwise. We can remove with other `UpdateSlaveMessage` in this test all together.

IMO we should be careful and only add necessary synchronizations so the test can help us to
capture unexpecetd races.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201355
-----------------------------------------------------------


On April 19, 2018, 4:39 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66220/
> -----------------------------------------------------------
> 
> (Updated April 19, 2018, 4:39 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66220/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message