mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66050: Implemented grow and shrink of persistent volumes.
Date Wed, 25 Apr 2018 04:06:51 GMT


> On April 16, 2018, 5:38 p.m., Gaston Kleiman wrote:
> > src/master/master.cpp
> > Lines 4931-4932 (patched)
> > <https://reviews.apache.org/r/66050/diff/10/?file=2002405#file2002405line4944>
> >
> >     I'd change this to:
> >     
> >     
> >     ```
> >     "Agent " + stringify(slave) + " does not have the required RESOURCE_PROVIDER
capability"
> >     ```
> >     
> >     To be consistent with what `Master::accept()` returns when an operation ID is
specified, but the agent doesn't support `RESOURCE_PROVIDER`.

Hmm I just noticed that you raised this, but this would be inconsistent with error messages
for other operations such as `CREATE_VOLUME` lol. As I suggested to move this into the validate
function, I'll create a follow-up patch to fix the inconsistencies in `CREATE_VOLUME` and
other operations.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/#review201229
-----------------------------------------------------------


On April 24, 2018, 9:16 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66050/
> -----------------------------------------------------------
> 
> (Updated April 24, 2018, 9:16 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new offer operations are implemented as speculative operations, but
> we will use validation to make them non-speculative on API level so that
> we can transition later without a breaking change.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp 78bffd8595f0e9f34e981548d8136ff94160573b 
>   src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
>   src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
>   src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 
> 
> 
> Diff: https://reviews.apache.org/r/66050/diff/13/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message