mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66733: Added a new `RESIZE_VOLUME` agent capability.
Date Wed, 25 Apr 2018 00:05:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66733/#review201880
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_tests.cpp
Lines 5051-5052 (original), 5051-5059 (patched)
<https://reviews.apache.org/r/66733/#comment283486>

    Nit: indent this block by two more spaces.



src/tests/slave_tests.cpp
Lines 1706-1707 (original), 1705-1713 (patched)
<https://reviews.apache.org/r/66733/#comment283487>

    Ditto.


- Chun-Hung Hsiao


On April 24, 2018, 9:16 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66733/
> -----------------------------------------------------------
> 
> (Updated April 24, 2018, 9:16 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4945
>     https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used as a feature flag to gate the new volume resize
> feature. This feature will be turn on by default once released.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5bc4a80ad5278d20feced73dce755519515de505 
>   include/mesos/v1/mesos.proto 5a4e733250831fa5fe86544aeb98dbc0a4f5afa6 
>   src/common/protobuf_utils.hpp ae060f3a7946ac5862faeca15330e9642f934137 
>   src/common/protobuf_utils.cpp 78bffd8595f0e9f34e981548d8136ff94160573b 
>   src/slave/constants.cpp 51de71bc45ff4fb862690efd9428b25d92055391 
>   src/slave/flags.cpp 0ee4f65b14b578c8f8de60d42dff0ee438cdd8a8 
>   src/tests/master_tests.cpp d5ce52c0eb1ba333d1b3dd35518545c13d828ce6 
>   src/tests/slave_tests.cpp ae82438a4f2f79820fe6d476e25b4915aa5f212c 
> 
> 
> Diff: https://reviews.apache.org/r/66733/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message