mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66778: Fixed Master which generated updates with the latest task state.
Date Tue, 24 Apr 2018 21:21:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66778/#review201863
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66778]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 24, 2018, 11:03 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66778/
> -----------------------------------------------------------
> 
> (Updated April 24, 2018, 11:03 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Megha Sharma.
> 
> 
> Bugs: MESOS-8824
>     https://issues.apache.org/jira/browse/MESOS-8824
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master should use `Task.status_update_state` to generate status
> updates during agent reregistration instead of `Task.state` because
> using the latter could result in the scheduler seeing out-of-order task
> state transitions (e.g., TASK_FINISHED -> TASK_RUNNING).
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
>   src/tests/partition_tests.cpp 606025a54dc54a777222c4dca5fd8c3c084031d2 
> 
> 
> Diff: https://reviews.apache.org/r/66778/diff/1/
> 
> 
> Testing
> -------
> 
> Make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message