mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66444: Windows: Deleted `stout/os/windows/signals.hpp`.
Date Tue, 24 Apr 2018 20:41:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66444/
-----------------------------------------------------------

(Updated April 24, 2018, 1:41 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park.


Summary (updated)
-----------------

Windows: Deleted `stout/os/windows/signals.hpp`.


Bugs: MESOS-8682
    https://issues.apache.org/jira/browse/MESOS-8682


Repository: mesos


Description (updated)
-------

This file had never been included before, so it didn't compile.
Because everything in this file will remain unimplemented, we chose to
delete the Windows version of the file entirely. The POSIX
implementation is left intact in `stout/os/posix/signals.hpp`, and the
primary header, `stout/os/signals.hpp` is a no-op on Windows. We do
this so that its inclusion does not need to be guarded, only the use
of the POSIX-specific APIs under `os::signals`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/signals.hpp 30e0f636647e5ddf7d6a2c4380eb0dc0b2428082 
  3rdparty/stout/include/stout/os/windows/signals.hpp 0ed24771625e58c1de8b1aa96b70f5aae1638bd4



Diff: https://reviews.apache.org/r/66444/diff/2/

Changes: https://reviews.apache.org/r/66444/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message