mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 63372: Added documentation for memory profiling.
Date Tue, 24 Apr 2018 17:59:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201844
-----------------------------------------------------------



Have you rendered using our website renderer?


docs/memory-profiling.md
Lines 26 (patched)
<https://reviews.apache.org/r/63372/#comment283450>

    s/:/.
    
    Maybe even better:
    ... support jemalloc only; there are several ways to connect it to Mesos.



docs/memory-profiling.md
Lines 51 (patched)
<https://reviews.apache.org/r/63372/#comment283454>

    Please decide whether or not to back tick jemalloc throughout the doc.



docs/memory-profiling.md
Lines 54 (patched)
<https://reviews.apache.org/r/63372/#comment283455>

    I would like to explicitly tell people that this is the second part, with the first being
switching to jemalloc. Also, I would like to educate them, that the second (memory profiling)
requires the first, while the opposite is not true and people will likely reap profit even
without enabling memory profiling functionlaity.
    
    Can you please add this info somewhere to the doc?



docs/memory-profiling.md
Lines 109 (patched)
<https://reviews.apache.org/r/63372/#comment283457>

    Nit: period ourside the link please


- Alexander Rukletsov


On April 24, 2018, 2:40 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> -----------------------------------------------------------
> 
> (Updated April 24, 2018, 2:40 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for memory profiling.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b 
>   docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f 
>   docs/memory-profiling.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63372/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message