mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.
Date Tue, 24 Apr 2018 01:12:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65995/
-----------------------------------------------------------

(Updated April 24, 2018, 1:12 a.m.)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jie Yu.


Changes
-------

Addressed Benjamin's comment and removed unnecessary `std::bind`.


Bugs: MESOS-8492
    https://issues.apache.org/jira/browse/MESOS-8492


Repository: mesos


Description
-------

The two SLRP tests assume that SLRP will send out a RAW resource in its
first `UPDATE_STATE` message, and expect that the test framework would
receive an offer containing the RAW resource in its first offer. However
this behavior is not guaranteed and should not be relied on. This patch
makes the tests decline unwanted offers by default so they no longer
rely on SLRP's internal behavior.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp ccb114aacc904998dfeef4128f6d38dfb3c865c7



Diff: https://reviews.apache.org/r/65995/diff/6/

Changes: https://reviews.apache.org/r/65995/diff/5-6/


Testing
-------

sudo make check
Ran the two tests in repitition.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message