mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66544: Remembered recovered and subscribed providers in ephemeral state.
Date Mon, 23 Apr 2018 00:53:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66544/#review201710
-----------------------------------------------------------




src/resource_provider/manager.cpp
Lines 215 (patched)
<https://reviews.apache.org/r/66544/#comment283263>

    In the master, we use `recovered` and `registered` to keep track of agents. Do you think
it is better to keep track of `known` that is a superset of `subscribed`, or make it into
two disjoint `recovered` and `subscribed` sets?


- Chun-Hung Hsiao


On April 11, 2018, 9:23 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66544/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 9:23 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8402
>     https://issues.apache.org/jira/browse/MESOS-8402
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a data structure to bookkeep subscribed and recovered
> resource providers in the ephemeral state of the resource provider
> manager.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
> 
> 
> Diff: https://reviews.apache.org/r/66544/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message