mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66753: Windows: Fixed build with OpenSSL due to missing header.
Date Sat, 21 Apr 2018 02:05:29 GMT


> On April 20, 2018, 6:42 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> > 
> > Reviews applied: `['66753']`
> > 
> > Failed command: `Start-MesosCITesting`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66753
> > 
> > Relevant logs:
> > 
> > - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66753/logs/mesos-tests-stdout.log):
> > 
> > ```
> > [       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (128 ms)
> > [----------] 9 tests from Endpoint/SlaveEndpointTest (1114 ms total)
> > 
> > [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
> > [ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
> > [       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (36 ms)
> > [ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
> > [       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (41 ms)
> > [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (80 ms total)
> > 
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest
> > [ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
> > [       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (742 ms)
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest (768 ms total)
> > 
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest
> > [ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
> > [       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (726 ms)
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest (750 ms total)
> > 
> > [----------] Global test environment tear-down
> > [==========] 956 tests from 94 test cases ran. (432286 ms total)
> > [  PASSED  ] 955 tests.
> > [  FAILED  ] 1 test, listed below:
> > [  FAILED  ] MesosContainerizer/DefaultExecutorTest.SigkillExecutor/0, where GetParam()
= "mesos"
> > 
> >  1 FAILED TEST
> >   YOU HAVE 214 DISABLED TESTS
> > 
> > ```
> > 
> > - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66753/logs/mesos-tests-stderr.log):
> > 
> > ```
> > I0421 01:42:33.695284 26280 executor.cpp:177] Received SUBSCRIBED event
> > I0421 01:42:33.700284 26280 executor.cpp:181] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
> > I0421 01:42:33.701284 26280 executor.cpp:177] Received LAUNCH event
> > I0421 01:42:33.705279 26280 executor.cpp:649] Starting task 43ad30bf-4c67-4f55-ad50-d35b462ae163
> > I0421 01:42:33.792289 26280 executor.cpp:484] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
> > I0421 01:42:33.806294 26280 executor.cpp:662] Forked command at 22416
> > I0421 01:42:33.840289 12860 exec.cpp:445] Executor asked to shutdown
> > I0421 01:42:33.841274 32472 executor.cpp:177] Received SHUTDOWN event
> > I0421 01:42:33.841274 32472 executor.cpp:759] Shutting down
> > I0421 01:42:33.841274 32472 executor.cpp:869] Sending SIGTERM to process tree at
pid ] Deactivating framework b973dca4-a467-4996-964e-a07bce194ca9-0000 (default) at scheduler-154e8bae-7b67-469a-886e-86711daae66f@10.3.1.8:57994
> > I0421 01:42:33.838289 30064 hierarchical.cpp:405] Deactivated framework b973dca4-a467-4996-964e-a07bce194ca9-0000
> > I0421 01:42:33.838289 31004 master.cpp:10453] Updating the state of task 43ad30bf-4c67-4f55-ad50-d35b462ae163
of framework b973dca4-a467-4996-964e-a07bce194ca9-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
> > I0421 01:42:33.838289 31852 slave.cpp:3923] Shutting down framework b973dca4-a467-4996-964e-a07bce194ca9-0000
> > I0421 01:42:33.838289 31852 slave.cpp:6620] Shutting down executor '43ad30bf-4c67-4f55-ad50-d35b462ae163'
of framework b973dca4-a467-4996-964e-a07bce194ca9-0000 at executor(1)@10.3.1.8:58015
> > I0421 01:42:33.839288 31852 slave.cpp:923] Agent terminating
> > W0421 01:42:33.839288 31852 slave.cpp:3919] Ignoring shutdown framework b973dca4-a467-4996-964e-a07bce194ca9-0000
because it is terminating
> > I0421 01:42:33.841274 31004 master.cpp:10552] Removing task 43ad30bf-4c67-4f55-ad50-d35b462ae163
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework b973dca4-a467-4996-964e-a07bce194ca9-0000 on agent b973dca4-a467-4996-964e-a07bce194ca9-S0
at slave(427)@10.3.1.8:57994 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0421 01:42:33.844292 30628 containerizer.cpp:2375] Destroying container 0d2190d1-7e8c-4d17-a3dd-7823cddff36e
in RUNNING state
> > I0421 01:42:33.844292 30628 containerizer.cpp:2989] Transitioning the state of container
0d2190d1-7e8c-4d17-a3dd-7823cddff36e from RUNNING to DESTROYING
> > I0421 01:42:33.845290 30628 launcher.cpp:156] Asked to destroy container 0d2190d1-7e8c-4d17-a3dd-7823cddff36e
> > I0421 01:42:33.845290 31004 master.cpp:1296] Agent b973dca4-a467-4996-964e-a07bce194ca9-S0
at slave(427)@10.3.1.8:57994 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
> > I0421 01:42:33.845290 31004 master.cpp:3287] Disconnecting agent b973dca4-a467-4996-964e-a07bce194ca9-S0
at slave(427)@10.3.1.8:57994 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0421 01:42:33.845290 29264 hierarchical.cpp:344] Removed framework b973dca4-a467-4996-964e-a07bce194ca9-0000
> > I0421 01:42:33.846289 31004 master.cpp:3306] Deactivating agent b973dca4-a467-4996-964e-a07bce194ca9-S0
at slave(427)@10.3.1.8:57994 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
> > I0421 01:42:33.846289 30064 hierarchical.cpp:766] Agent b973dca4-a467-4996-964e-a07bce194ca9-S0
deactivated
> > I0421 01:42:33.859292 32364 containerizer.cpp:2828] Container 0d2190d1-7e8c-4d17-a3dd-7823cddff36e
has exited
> > I0421 01:42:33.894285 32388 master.cpp:1138] Master terminating
> > I0421 01:42:33.897289 28120 hierarchical.cpp:609] Removed agent b973dca4-a467-4996-964e-a07bce194ca9-S0
> > I0421 01:42:34.407295 30884 process.cpp:939] Stopped the socket accept loop
> > ```

Flaky maybe? It has nothing to do with this change.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66753/#review201681
-----------------------------------------------------------


On April 20, 2018, 6:32 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66753/
> -----------------------------------------------------------
> 
> (Updated April 20, 2018, 6:32 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Chun-Hung Hsiao, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When `-DENABLE_SSL=TRUE`, then `USE_SSL_SOCKET` is defined, and in
> this `src/local/local.cpp` in a section guarded by said definition,
> the construct `os::Permissions` is used. However, this is defined in
> `stout/os/permissions.hpp`, which is implicitly included on POSIX, but
> not on Windows. The fix is to IWYU and explicitly include it.
> 
> 
> Diffs
> -----
> 
>   src/local/local.cpp 9c5b45b7c4e7705861f1e7926847711dc16f1264 
> 
> 
> Diff: https://reviews.apache.org/r/66753/diff/2/
> 
> 
> Testing
> -------
> 
> Built on Windows with `-DENABLE_SSL`. Previously it failed due to `os::Permissions` being
undefined.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message