mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66753: Windows: Fixed build with OpenSSL due to missing header.
Date Sat, 21 Apr 2018 01:32:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66753/
-----------------------------------------------------------

(Updated April 20, 2018, 6:32 p.m.)


Review request for mesos, Akash Gupta, Chun-Hung Hsiao, and Joseph Wu.


Repository: mesos


Description (updated)
-------

When `-DENABLE_SSL=TRUE`, then `USE_SSL_SOCKET` is defined, and in
this `src/local/local.cpp` in a section guarded by said definition,
the construct `os::Permissions` is used. However, this is defined in
`stout/os/permissions.hpp`, which is implicitly included on POSIX, but
not on Windows. The fix is to IWYU and explicitly include it.


Diffs (updated)
-----

  src/local/local.cpp 9c5b45b7c4e7705861f1e7926847711dc16f1264 


Diff: https://reviews.apache.org/r/66753/diff/2/

Changes: https://reviews.apache.org/r/66753/diff/1-2/


Testing
-------

Built on Windows with `-DENABLE_SSL`. Previously it failed due to `os::Permissions` being
undefined.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message