mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66753: Windows: Fixed build with OpenSSL due to missing header.
Date Sat, 21 Apr 2018 01:12:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66753/#review201679
-----------------------------------------------------------


Fix it, then Ship it!




Could you update the commit message to make "this file" more specific?


src/local/local.cpp
Lines 60 (patched)
<https://reviews.apache.org/r/66753/#comment283203>

    Grouping a public header and a private header with this condition looks a litter weird
;) How about having two pairs of `#ifdef`?


- Chun-Hung Hsiao


On April 20, 2018, 11:52 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66753/
> -----------------------------------------------------------
> 
> (Updated April 20, 2018, 11:52 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Chun-Hung Hsiao, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When `-DENABLE_SSL=TRUE`, then `USE_SSL_SOCKET` is defined, and in
> this file in a section guarded by the definition, the construct
> `os::Permissions` is used. However, this is defined in
> `stout/os/permissions.hpp`, which is implicitly included on POSIX, but
> not on Windows. The fix is to IWYU and explicitly include it.
> 
> 
> Diffs
> -----
> 
>   src/local/local.cpp 9c5b45b7c4e7705861f1e7926847711dc16f1264 
> 
> 
> Diff: https://reviews.apache.org/r/66753/diff/1/
> 
> 
> Testing
> -------
> 
> Built on Windows with `-DENABLE_SSL`. Previously it failed due to `os::Permissions` being
undefined.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message