> On April 20, 2018, 4:08 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/grpc-1.10.0.patch
> > Lines 9-19 (patched)
> > <https://reviews.apache.org/r/66727/diff/1/?file=2007020#file2007020line9>
> >
> > We discussed this a bit, and it's just... weird. gRPC should not be _requiring_
`_WIN32_WINNT` to be defined.
> >
> > Chun, I think, perhaps, could we just change `#error` to `#warning`? Changing
the ordering also ensure it gets defined before the check, but really just solves our problem
by happenstance.
Actually, I'm dropping this. This approach is reasonable as `windows.h` will include `sdkddkver.h`,
which has the following code:
```
#if !defined(_WIN32_WINNT) && !defined(_CHICAGO_)
#define _WIN32_WINNT 0x0A00
#endif
```
Thus by moving `#include <windows.h>` up, the SDK will define `_WIN32_WINNT` for us
if and only if we hadn't previously defined it, and gRPC's version checking logic will still
work as intended.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66727/#review201661
-----------------------------------------------------------
On April 19, 2018, 7:24 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66727/
> -----------------------------------------------------------
>
> (Updated April 19, 2018, 7:24 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.
>
>
> Bugs: MESOS-7881
> https://issues.apache.org/jira/browse/MESOS-7881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We added a gRPC patch file that includes
> https://github.com/grpc/grpc/pull/15128 to fix Windows compilation, and
> updated `grpc.md` to match the format of `protobuf.md`.
>
>
> Diffs
> -----
>
> 3rdparty/grpc-1.10.0.patch PRE-CREATION
> 3rdparty/grpc-1.10.0.readme d33a80881f9660e95cf3c2b032b3053d5ed9c7ff
> 3rdparty/grpc.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/66727/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
|