mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 61096: Building gRPC with CMake.
Date Fri, 20 Apr 2018 23:09:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/#review201662
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On April 20, 2018, 3:18 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61096/
> -----------------------------------------------------------
> 
> (Updated April 20, 2018, 3:18 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph
Wu.
> 
> 
> Bugs: MESOS-7881
>     https://issues.apache.org/jira/browse/MESOS-7881
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
> 3rdparty library in CMake.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9 
>   3rdparty/cmake/Versions.cmake 33577cc86d3ef31e129b8ea55d44d3fee02d4a30 
>   cmake/CompilationConfigure.cmake 173089a1ebf80a6288431075770a807235524ac1 
>   src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc 
> 
> 
> Diff: https://reviews.apache.org/r/61096/diff/12/
> 
> 
> Testing
> -------
> 
> `cmake .. -DENABLE_GRPC=1` then `cmake --build .` on both Linux and Windows.
> 
> NOTE: libprocess-tests will be failed to build on Windows with VS. This is fixed in the
next patch.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message