mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 66489: Cleaned up internal evolve functions.
Date Fri, 20 Apr 2018 22:47:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66489/
-----------------------------------------------------------

(Updated April 20, 2018, 3:47 p.m.)


Review request for mesos and Greg Mann.


Changes
-------

Rebased.


Bugs: MESOS-8191
    https://issues.apache.org/jira/browse/MESOS-8191


Repository: mesos


Description
-------

This patch removes the `mesos::` prefix from declarations where
possible, uses a consistent number of empty lines in the header,
and reorders some declarations.


Diffs (updated)
-----

  src/internal/evolve.hpp e00ac7175438f758b10c0aa9485fc29ffa4efa29 
  src/internal/evolve.cpp f598ea11b64bdbface5bf1f124a02ea876196b67 


Diff: https://reviews.apache.org/r/66489/diff/2/

Changes: https://reviews.apache.org/r/66489/diff/1-2/


Testing
-------

`sudo bin/mesos-tests` on GNU/Linux


Thanks,

Gaston Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message