mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66464: Implemented operation status reconciliation.
Date Fri, 20 Apr 2018 22:24:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66464/#review201657
-----------------------------------------------------------




src/master/master.cpp
Lines 8929-8933 (patched)
<https://reviews.apache.org/r/66464/#comment283182>

    I think this case is actually "Operation is unknown, slave is unknown" since the scheduler
specified an agent ID, but we didn't locate it in any of the agent maps.
    
    Maybe the message here should be something like "Reconciliation: Both operation and agent
are unknown"?



src/master/master.cpp
Lines 8939 (patched)
<https://reviews.apache.org/r/66464/#comment283184>

    I think this message should be "Reconciliation: Operation is unknown".
    
    Maybe we should elaborate a bit and say "Reconciliation: Operation is unknown and no 'agent_id'
was provided"? I mean, they should know they didn't provide an agent ID :) But this might
be useful? Not sure.


- Greg Mann


On April 18, 2018, 9:36 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66464/
> -----------------------------------------------------------
> 
> (Updated April 18, 2018, 9:36 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8191
>     https://issues.apache.org/jira/browse/MESOS-8191
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented operation status reconciliation.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
> 
> 
> Diff: https://reviews.apache.org/r/66464/diff/5/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> https://reviews.apache.org/r/66468/ adds new tests.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message