mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66726: Made CMake's `FindZLIB` module be able to find Zlib on Windows.
Date Fri, 20 Apr 2018 21:13:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66726/#review201650
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On April 19, 2018, 7:23 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66726/
> -----------------------------------------------------------
> 
> (Updated April 19, 2018, 7:23 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.
> 
> 
> Bugs: MESOS-7881
>     https://issues.apache.org/jira/browse/MESOS-7881
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch "install" ZLib in `build/3rdparty/zlib-1.2.8/src/zlib-1.2.8`,
> so we can set `ZLIB_ROOT` to the directory to make `FindZLIB` be able to
> find the include directory containing both `zlib.h` and `zconf.h`, as
> well as to find the library directory containing the library files.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9 
> 
> 
> Diff: https://reviews.apache.org/r/66726/diff/1/
> 
> 
> Testing
> -------
> 
> cmake --build .
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message