mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harold Dost <h.d...@criteo.com>
Subject Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.
Date Fri, 20 Apr 2018 18:48:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66001/
-----------------------------------------------------------

(Updated April 20, 2018, 6:48 p.m.)


Review request for mesos and James Peach.


Bugs: MESOS-6575
    https://issues.apache.org/jira/browse/MESOS-6575


Repository: mesos


Description
-------

New Flags for disk/xfs isolator:
- xfs_kill_containers - This will create a 10 MB buffer between the soft
    and hard limits, and when the soft limit is exceeded it will
    subsequently be killed.

Functionality
- This by default disabled behavior allows for the `disk/xfs` isolator
    to kill containers which surpass their limit.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 07e68a777aefba4dd35066f2eb207bba7f199d83

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 8d9f8f846866f9de377c59cb7fb311041283ba70

  src/slave/containerizer/mesos/isolators/xfs/utils.hpp e034133629a9c1cf58b776f8da2a93421332cee0

  src/slave/containerizer/mesos/isolators/xfs/utils.cpp 2708524add1ff693b616d4fb241c4a0a3070520b

  src/slave/flags.hpp 4195d3b4170c5fa0348b63ed19e18dd208593975 
  src/slave/flags.cpp e330e5fa0b49ad1d1765e492bc44a262a7856db5 
  src/tests/containerizer/xfs_quota_tests.cpp 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 


Diff: https://reviews.apache.org/r/66001/diff/14/

Changes: https://reviews.apache.org/r/66001/diff/13-14/


Testing
-------


Thanks,

Harold Dost


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message