mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 62472: Fixed the ordering of Mesos containerizer isolators.
Date Fri, 20 Apr 2018 05:17:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62472/#review201608
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62472]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 19, 2018, 9:22 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62472/
> -----------------------------------------------------------
> 
> (Updated April 19, 2018, 9:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7643
>     https://issues.apache.org/jira/browse/MESOS-7643
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Historically, isolators were invoked in the order listed by
> the operator in the `--isolation` flag. This changed to an
> internal ordering in 6fb9c024, back to the operator ordering
> in af474a6fa, and then to an undefined ordering in 9642d3c67b.
> 
> This commit switches back to an internal ordering for all the built-in
> isolators. Custom isolators loaded in modules are run in operator order
> after all the built-in ones. The rationale for an internal ordering is
> expressed in MESOS-5581; basically we should not burden the operator
> with having to figure out how to make the order correct. In the case of
> custom isolators there's no way for us to know the correct ordering so
> we make an arbitrary choice.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 6568126252a0a8ff5f6095bedae7828a9a1ba0fd

> 
> 
> Diff: https://reviews.apache.org/r/62472/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> Posting this as an RFC. If reviewers are OK with the approach, I'll float it on users@
and dev@ and update the documentation.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message