mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 61118: Building gRPC support in libprocess with CMake.
Date Fri, 20 Apr 2018 02:31:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61118/
-----------------------------------------------------------

(Updated April 20, 2018, 2:31 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
-------

Enabled Windows build.


Bugs: MESOS-7881
    https://issues.apache.org/jira/browse/MESOS-7881


Repository: mesos


Description
-------

This patch enables CMake to build code for gRPC support in libprocess
along with tests.


Diffs (updated)
-----

  3rdparty/libprocess/src/CMakeLists.txt 1eca50a4d513b2fead111e453565edff0a3ee497 
  3rdparty/libprocess/src/tests/CMakeLists.txt d624402bc9efb43a130a2afdf27cfc1aa69010e4 


Diff: https://reviews.apache.org/r/61118/diff/6/

Changes: https://reviews.apache.org/r/61118/diff/5-6/


Testing (updated)
-------

`cmake .. -DENABLE_GRPC=1` and then `cmake --build . --target check` on Linux and Windows.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message