mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 66726: Made CMake's `FindZLIB` module be able to find Zlib on Windows.
Date Fri, 20 Apr 2018 02:23:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66726/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.


Bugs: MESOS-7881
    https://issues.apache.org/jira/browse/MESOS-7881


Repository: mesos


Description
-------

This patch "install" ZLib in `build/3rdparty/zlib-1.2.8/src/zlib-1.2.8`,
so we can set `ZLIB_ROOT` to the directory to make `FindZLIB` be able to
find the include directory containing both `zlib.h` and `zconf.h`, as
well as to find the library directory containing the library files.


Diffs
-----

  3rdparty/CMakeLists.txt e6bb4076e630d78e73a82a93b1f64b3bc5d859b9 


Diff: https://reviews.apache.org/r/66726/diff/1/


Testing
-------

cmake --build .


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message