mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 66705: Propagated executor sandbox creation errors.
Date Fri, 20 Apr 2018 00:42:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66705/#review201592
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On April 20, 2018, 1:52 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66705/
> -----------------------------------------------------------
> 
> (Updated April 20, 2018, 1:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8585
>     https://issues.apache.org/jira/browse/MESOS-8585
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rather than crashing if the agent fails to create the executor
> directory, propagate the error to the caller so that it can
> handle it appropriately.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp fe5ab9e7f96d69069406e2714ab676a5bb070534 
>   src/slave/paths.cpp 690bfe3587e6d728ab6eb712a913de23c4abe353 
>   src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 
>   src/tests/paths_tests.cpp dc765ed9db7a8ac7ca0bcb4af5cf353547ba881f 
> 
> 
> Diff: https://reviews.apache.org/r/66705/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message