mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.
Date Thu, 19 Apr 2018 23:53:57 GMT


> On April 17, 2018, 6:25 p.m., Chun-Hung Hsiao wrote:
> > src/tests/api_tests.cpp
> > Lines 3688 (patched)
> > <https://reviews.apache.org/r/66227/diff/4/?file=1996769#file1996769line3688>
> >
> >     Let's try to split the test into two so each test verifies one operation.
> >     
> >     Also, what's the reason of disabling the test on Windows?
> >     
> >     And do you think it is reasonable to have tests that leave `agent_id` unset,
to expose the code path of validating the existence of `agent_id`?

Persistent volume creation is not working on Windows yet.

I'm okay to add some check about the validation of mising `agent_id`.


> On April 17, 2018, 6:25 p.m., Chun-Hung Hsiao wrote:
> > src/tests/api_tests.cpp
> > Lines 3766 (patched)
> > <https://reviews.apache.org/r/66227/diff/4/?file=1996769#file1996769line3766>
> >
> >     Not sure if this is necessary. Could you justify the need of this synchronization?

I'll see whether this is necessary. In the other test, this is necessary if we rely on offers
to reflect operation result: to work around possible race condition between calling `allocation->updateAllocation()`
and clock::advance.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66227/#review201366
-----------------------------------------------------------


On April 11, 2018, 2:21 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66227/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 2:21 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-8747
>     https://issues.apache.org/jira/browse/MESOS-8747
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 
> 
> 
> Diff: https://reviews.apache.org/r/66227/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message